Re: Bug in ViewResponseHelper.java of 4627fb2

2018-01-04 Thread Tutkowski, Mike
Hi everyone, Just wanted to follow up on this. I was going to open a PR on this, but I realized after a rebase that it had been fixed already in this commit: 4627fb2. Talk to you later! Mike On 12/18/17, 6:33 PM, "Tutkowski, Mike" wrote: I’m not at my computer now, so don’t know the exact

Re: Bug in ViewResponseHelper.java of 4627fb2

2017-12-20 Thread Rohit Yadav
Hi Mike, Yes, please send a PR! - Rohit From: Tutkowski, Mike Sent: Tuesday, December 19, 2017 2:08:42 AM To: dev@cloudstack.apache.org Subject: Bug in ViewResponseHelper.java of 4627fb2 Hi, I noticed an issue today with a fairly recent commit: 4627fb2. In

Re: Bug in ViewResponseHelper.java of 4627fb2

2017-12-18 Thread Tutkowski, Mike
I’m not at my computer now, so don’t know the exact line number. I can open up a PR with my fix. The problem is that you shouldn’t pass in null for the key of a ConcurrentHashMap, but the code can do this for data disks on VMware (hence the NullPointerException). On Dec 18, 2017, at 4:48 PM, R

Re: Bug in ViewResponseHelper.java of 4627fb2

2017-12-18 Thread Rafael Weingärtner
What is the line in that class that may generate a NPE? 291? Please do open a PR to propose a fix for this situation. On Mon, Dec 18, 2017 at 6:38 PM, Tutkowski, Mike wrote: > Hi, > > I noticed an issue today with a fairly recent commit: 4627fb2. > > In ViewResponseHelper.java, a NullPointerExce