Re: Adding git commit ids to our packaging...

2013-07-17 Thread Prasanna Santhanam
ers [mailto:chip.child...@sungard.com] > > Sent: Friday, July 12, 2013 6:53 AM > > To: dev@cloudstack.apache.org > > Subject: Re: Adding git commit ids to our packaging... > > > > On Fri, Jul 12, 2013 at 09:48:12AM -0400, David Nalley wrote: > > > On Thu, Jul

Re: Adding git commit ids to our packaging...

2013-07-12 Thread Rohit Yadav
+1 Would help users verify the git sha and for reference. Cheers. On Fri, Jul 12, 2013 at 6:06 AM, Alex Huang wrote: > Hi All, > > I added the branch and git commit id to the war file. You can find it by > opening the war file and retrieving the META-INF/MANIFEST.MF. Inside, > there is a Impl

RE: Adding git commit ids to our packaging...

2013-07-12 Thread Alex Huang
m: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Friday, July 12, 2013 6:53 AM > To: dev@cloudstack.apache.org > Subject: Re: Adding git commit ids to our packaging... > > On Fri, Jul 12, 2013 at 09:48:12AM -0400, David Nalley wrote: > > On Thu, Jul 11, 2013 at 11:05 PM, Alex Huang

Re: Adding git commit ids to our packaging...

2013-07-12 Thread Chip Childers
On Fri, Jul 12, 2013 at 09:48:12AM -0400, David Nalley wrote: > On Thu, Jul 11, 2013 at 11:05 PM, Alex Huang wrote: > > Will work on making it nicer but do we want to put this information into > > release? Is there any harm to have this in the release build? I can't > > think of any off-hand.

Re: Adding git commit ids to our packaging...

2013-07-12 Thread David Nalley
On Thu, Jul 11, 2013 at 11:05 PM, Alex Huang wrote: > Will work on making it nicer but do we want to put this information into > release? Is there any harm to have this in the release build? I can't think > of any off-hand. If we don't want them, we can change build_asf.sh to set > those tw

RE: Adding git commit ids to our packaging...

2013-07-11 Thread Alex Huang
I might be able to get it to read this information from a file instead. --Alex > -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Thursday, July 11, 2013 6:35 PM > To: > Subject: Re: Adding git commit ids to our packaging... > &g

Re: Adding git commit ids to our packaging...

2013-07-11 Thread Chip Childers
Cool. +1 then On Jul 11, 2013, at 9:28 PM, David Nalley wrote: > I was worried about the same thing, but ran build_asf.sh to create a > tarball and then built it. > > Here's the resulting output, which isn't perfectly nice, but also isn't > broken. > > ke4qqq@mba ~/apache-cloudstack-4.2.0-RC2-s

Re: Adding git commit ids to our packaging...

2013-07-11 Thread David Nalley
I was worried about the same thing, but ran build_asf.sh to create a tarball and then built it. Here's the resulting output, which isn't perfectly nice, but also isn't broken. ke4qqq@mba ~/apache-cloudstack-4.2.0-RC2-src/client/target/META-INF[master*]$ cat MANIFEST.MF Manifest-Version: 1.0 Imple

Re: Adding git commit ids to our packaging...

2013-07-11 Thread Chip Childers
Is it off by default? Our releases aren't from git. On Jul 11, 2013, at 8:38 PM, Alex Huang wrote: > Hi All, > > I added the branch and git commit id to the war file. You can find it by > opening the war file and retrieving the META-INF/MANIFEST.MF. Inside, there > is a Implementation-Revis

Re: Adding git commit ids to our packaging...

2013-07-11 Thread Kelven Yang
+1 On 7/11/13 5:36 PM, "Alex Huang" wrote: >Hi All, > >I added the branch and git commit id to the war file. You can find it by >opening the war file and retrieving the META-INF/MANIFEST.MF. Inside, >there is a Implementation-Revision which contains the git commit id and a >Implementation-