Re: [SHOW] Authentication refactoring

2014-08-14 Thread Min Chen
Sorry, I might just get part of your commit yesterday when I looked. Now I saw them. Thanks for your clarification. -min On 8/14/14 10:01 AM, "Rohit Yadav" wrote: > >On 14-Aug-2014, at 6:54 pm, Min Chen wrote: > >> Hi Rohit, >> >> Any reason why you didn't implement response class for login a

Re: [SHOW] Authentication refactoring

2014-08-14 Thread Rohit Yadav
On 14-Aug-2014, at 6:54 pm, Min Chen wrote: > Hi Rohit, > > Any reason why you didn't implement response class for login and logout > like any other API cmd? I think that will be useful as mentioned in your > FS. In cloud-api, checkout org.apache.cloudstack.api.response.{LoginCmdResponse, Logo

Re: [SHOW] Authentication refactoring

2014-08-14 Thread Rohit Yadav
Hi Min, On 14-Aug-2014, at 6:54 pm, Min Chen wrote: > Hi Rohit, > > Any reason why you didn't implement response class for login and logout > like any other API cmd? I think that will be useful as mentioned in your > FS. Checkout LoginResponse and LogoutResponse :) also read the annotation in

Re: [SHOW] Authentication refactoring

2014-08-14 Thread Min Chen
Hi Rohit, Any reason why you didn't implement response class for login and logout like any other API cmd? I think that will be useful as mentioned in your FS. Thanks -min On 8/12/14 2:10 AM, "Rohit Yadav" wrote: >This was done: >https://cwiki.apache.org/confluence/displ

Re: [SHOW] Authentication refactoring

2014-08-13 Thread Rohit Yadav
Hi David, On 13-Aug-2014, at 5:10 am, David Nalley wrote: > On Tue, Aug 12, 2014 at 5:35 PM, Rohit Yadav > wrote: >> Hi Min, >> >> For for master, we don’t have any code freeze currently, I think merge >> request/reviews are not mandatory and I was confident with the changes so I >> pushed i

Re: [SHOW] Authentication refactoring

2014-08-13 Thread Daan Hoogland
On Wed, Aug 13, 2014 at 5:10 AM, David Nalley wrote: > Code freeze means that we discuss every commit, and only critical or > blocker bug fixes make it in. Which in practice means: RM reviews quickly and cherry-picks/merges it. -- Daan

Re: [SHOW] Authentication refactoring

2014-08-12 Thread David Nalley
On Tue, Aug 12, 2014 at 5:35 PM, Rohit Yadav wrote: > Hi Min, > > For for master, we don’t have any code freeze currently, I think merge > request/reviews are not mandatory and I was confident with the changes so I > pushed it on master. > This is an incorrect understanding of our community nor

Re: [SHOW] Authentication refactoring

2014-08-12 Thread Rohit Yadav
Perhaps a source IP ACL so that only >> specified >>> IPs can use a standard auth method but all other access mandates OTP/2FA? >>> Not sure how AWS works with their MFA feature - anyone? >> MFA is used for accessing UI console where you manage your keys for API >>

Re: [SHOW] Authentication refactoring

2014-08-12 Thread Silvano Nogueira Buback
for accessing UI console where you manage your keys for API > usage. > API access is controlled via IAM or key/secret which you manage from the UI > > > > I'm afraid I'm just a (ab)user and couldn't program anything myself - > just > > curious to see i

Re: [SHOW] Authentication refactoring

2014-08-12 Thread Rohit Yadav
Hi Min, For for master, we don’t have any code freeze currently, I think merge request/reviews are not mandatory and I was confident with the changes so I pushed it on master. After Daan’s email I did testing at my end (I’ve bunch of zotac zboxes to do the local testing, it was already failing

Re: [SHOW] Authentication refactoring

2014-08-12 Thread Min Chen
Hi Rohit, My understanding is that you will do this on your feature branch "auth-refactor", then merge them after passing at least some CI automation tests. Today, I saw all these commits already in master: 10 hours agoRohit Yadav DefaultLoginAPIAuthenticatorCmd: return userId as U

Re: [SHOW] Authentication refactoring

2014-08-12 Thread Carlos Reategui
? > > Cheers, > > Adrian > > -Original Message- > From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] > Sent: 12 August 2014 11:41 > To: dev@cloudstack.apache.org > Subject: Re: [SHOW] Authentication refactoring > > From the user end there is no ch

Re: [SHOW] Authentication refactoring

2014-08-12 Thread Rohit Yadav
l purpose SAML SSO/SLO integration (branch: origin/saml2) right now which is a sponsored project that we’re working in open, contributing directly to ACS and was a reason for me to do the refactoring. Cheers. > Cheers, > > Adrian > > -Original Message----- > From: R

RE: [SHOW] Authentication refactoring

2014-08-12 Thread Adrian Lewis
al Message- From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent: 12 August 2014 11:41 To: dev@cloudstack.apache.org Subject: Re: [SHOW] Authentication refactoring >From the user end there is no change, not in UI or any change expected in clients except one: Since login and logout are now implement

Re: [SHOW] Authentication refactoring

2014-08-12 Thread Rohit Yadav
>From the user end there is no change, not in UI or any change expected in >clients except one: Since login and logout are now implemented like your regular api, we don’t allow uses to call login and logout and other such AuthenticatorAPIs directly like via integration port Stephen, I’m not sur

RE: [SHOW] Authentication refactoring

2014-08-12 Thread Stephen Turner
Are there any UI changes? Some auth mechanisms might need more than just username and password (RSA token, for example, or even just "give the 1st, 4th and 5th characters"). -- Stephen Turner -Original Message- From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent: 12 August 2014

Re: [SHOW] Authentication refactoring

2014-08-12 Thread Rohit Yadav
On 12-Aug-2014, at 11:32 am, Daan Hoogland wrote: > looks alright at first glance. did you considder IAM/is it going to > give conflicts there? I don't suppose so as this work is more of a > front end thing and IAM should be more based in the background but > keep it in mind anyway;) > No reason

Re: [SHOW] Authentication refactoring

2014-08-12 Thread Daan Hoogland
looks alright at first glance. did you considder IAM/is it going to give conflicts there? I don't suppose so as this work is more of a front end thing and IAM should be more based in the background but keep it in mind anyway;) No reason why you shouldn't merge, except feature freeze.. On Tue, Aug

Re: [SHOW] Authentication refactoring

2014-08-12 Thread Rohit Yadav
This was done: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Authentication+Refactoring This is the branch: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/auth-refactor Updates: - Every auth mechanism now implements as a APICommand but these are special