Re: [PR] adding updateVlanIpRange [cloudstack-go]

2023-12-01 Thread via GitHub
DaanHoogland merged PR #75: URL: https://github.com/apache/cloudstack-go/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudst

Re: [PR] adding updateVlanIpRange [cloudstack-go]

2023-11-30 Thread via GitHub
DaanHoogland commented on PR #75: URL: https://github.com/apache/cloudstack-go/pull/75#issuecomment-1833329407 @harikrishna-patnala can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] adding updateVlanIpRange [cloudstack-go]

2023-11-28 Thread via GitHub
poddm commented on PR #75: URL: https://github.com/apache/cloudstack-go/pull/75#issuecomment-1830361100 @DaanHoogland, updated test data for createVlanIpRange, updateVlanIpRange, listVlanIpRanges and deleteVlanIpRange. ``` $ /opt/homebrew/bin/go test -timeout 30s -run ^TestVLANServ

Re: [PR] adding updateVlanIpRange [cloudstack-go]

2023-11-28 Thread via GitHub
DaanHoogland commented on PR #75: URL: https://github.com/apache/cloudstack-go/pull/75#issuecomment-1829784500 according to https://github.com/apache/cloudstack-go/actions/runs/7012770058/job/19085665052?pr=75#step:6:943 this is not tested in the H action. Code looks good but that test n