fabiomatavelli commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2168415802
@vishesh92 issues fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640111066
##
cloudstack/resource_cloudstack_network.go:
##
@@ -176,14 +175,12 @@ func resourceCloudStackNetworkCreate(d
*schema.ResourceData, meta inte
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640109567
##
cloudstack/resource_cloudstack_disk_test.go:
##
@@ -228,6 +228,7 @@ resource "cloudstack_disk" "foo" {
const testAccCloudStackDisk_deviceI
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640110316
##
cloudstack/resource_cloudstack_ipaddress_test.go:
##
@@ -137,14 +137,15 @@ func testAccCheckCloudStackIPAddressDestroy(s
*terraform.State)
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640110141
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -404,16 +409,17 @@ resource "cloudstack_instance" "foobar" {
name = "terraform-te
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640109989
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -372,6 +375,7 @@ resource "cloudstack_instance" "foobar" {
const testAccCloudStackI
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640109823
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -312,6 +312,7 @@ func testAccCheckCloudStackInstanceDestroy(s
*terraform.State) err
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639582074
##
cloudstack/provider_test.go:
##
@@ -20,56 +20,79 @@
package cloudstack
import (
+ "context"
"os"
"testing"
-
vishesh92 commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2167283327
@fabiomatavelli I have reviewed the PR. Changes looks good. I have left
comments where I have some questions about the changes.
Apart from this, there are sinor cod
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639312096
##
cloudstack/resource_cloudstack_network.go:
##
@@ -176,14 +175,12 @@ func resourceCloudStackNetworkCreate(d
*schema.ResourceData, meta interface
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639297478
##
cloudstack/resource_cloudstack_ipaddress_test.go:
##
@@ -137,14 +137,15 @@ func testAccCheckCloudStackIPAddressDestroy(s
*terraform.State) erro
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639297273
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -404,16 +409,17 @@ resource "cloudstack_instance" "foobar" {
name = "terraform-test"
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639297083
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -353,6 +355,7 @@ resource "cloudstack_instance" "foobar" {
const testAccCloudStackInstan
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639296948
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -312,6 +312,7 @@ func testAccCheckCloudStackInstanceDestroy(s
*terraform.State) error {
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639296109
##
cloudstack/resource_cloudstack_firewall_test.go:
##
@@ -188,14 +188,15 @@ func testAccCheckCloudStackFirewallDestroy(s
*terraform.State) error
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639294876
##
cloudstack/resource_cloudstack_disk_test.go:
##
@@ -228,6 +228,7 @@ resource "cloudstack_disk" "foo" {
const testAccCloudStackDisk_deviceID = `
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639289992
##
cloudstack/provider_test.go:
##
@@ -20,56 +20,79 @@
package cloudstack
import (
+ "context"
"os"
"testing"
- "
vishesh92 commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2166411819
@fabiomatavelli @poddm I am running a little busy these days. Let me review
this PR by next week.
--
This is an automated message from the Apache Git Service.
To re
fabiomatavelli commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2155673023
@poddm @rohityadavcloud what is the next step then? Can we merge it? It's
all good to be merged so we can continue working on other PRs
--
This is an automate
poddm commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2155146161
> @poddm @fabiomatavelli @rohityadavcloud What are we waiting on to get this
updated? I was looking into testing some other stuff and noticed the version of
the cloudstac
CodeBleu commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2155132268
@poddm @fabiomatavelli @rohityadavcloud What are we waiting on to get this
updated? I was looking into testing some other stuff and noticed the version
of the cloudst
fabiomatavelli commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2098846338
@rohityadavcloud thanks, it's working now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
rohityadavcloud commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2098789039
@fabiomatavelli the infra team has enabled the action, can you try again?
--
This is an automated message from the Apache Git Service.
To respond to the messag
rohityadavcloud closed pull request #71: Update SDKs
URL: https://github.com/apache/cloudstack-terraform-provider/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
fabiomatavelli commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2081447173
@rohityadavcloud those are the ones that we are using in the acceptance test
CI:
- `actions/setup-go@v5`
- `hashicorp/setup-terraform@v3`
- `opentofu
rohityadavcloud commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2081392297
@fabiomatavelli the ASF infra doesn't allow any actions to be used, if it's
not running, likely it's not allow. Can you send me (list of?) all the GitHub
Action
fabiomatavelli commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2080915377
Looks like the `opentofu/setup-opentofu@v1` action is not allowed. Is it
possible to allow it @rohityadavcloud ?
--
This is an automated message from the Apach
fabiomatavelli commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2080450193
@rohityadavcloud I've added the OpenTofu acceptance test CI also as
suggested by @CodeBleu . If you can allow the actions again so we can check the
run 🙏
--
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1581799304
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLO
CodeBleu commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1581168828
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLOUDSTAC
rohityadavcloud commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2078833695
Thanks @fabiomatavelli tests kicked, let's see what Github actions do.
--
This is an automated message from the Apache Git Service.
To respond to the message,
fabiomatavelli commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2078807528
Done @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1580587876
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLO
rohityadavcloud commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2078607496
@fabiomatavelli can you resolve the conflicts, thanks. I've approved the
Github actions to start running tests, thanks for the PR.
--
This is an automated mes
poddm commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1580420791
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLOUDSTACK_A
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1527183574
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLO
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1527183574
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLO
fabiomatavelli commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2002004950
> @fabiomatavelli TF Plugin be a v0.7.0 milestone?
Could be. Also with
[muxing](https://developer.hashicorp.com/terraform/plugin/framework/migrating#muxing
CodeBleu commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2000607396
> @CodeBleu I was looking into migrating directly to the terraform plugin
framework and it will require a huge effort for that. It will be not as simple
as migrating f
fabiomatavelli commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2000343098
@vishesh92 @rohityadavcloud I've added another matrix to the acceptance test
so multiple versions of terraform can be tested.
--
This is an automated message f
fabiomatavelli commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2000341643
@CodeBleu I was looking into migrating directly to the terraform plugin
framework and it will require a huge effort for that. It will be not as simple
as migrati
fabiomatavelli commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1975257114
Indeed, I haven't seen the Terraform Plugin Framework at the time I did it.
If you think it is better to go straight to it, then I can close this one
@CodeBleu @
vishesh92 closed pull request #71: Update SDKs
URL: https://github.com/apache/cloudstack-terraform-provider/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
CodeBleu commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1972063395
> > If there is going to be SDK updates, why not just go to the [Terraform
Plugin
Framework](https://developer.hashicorp.com/terraform/plugin/framework/migrating)
ins
poddm commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1971724096
> If there is going to be SDK updates, why not just go to the [Terraform
Plugin
Framework](https://developer.hashicorp.com/terraform/plugin/framework/migrating)
instead?
rohityadavcloud commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1953109896
Rekicking build check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rohityadavcloud closed pull request #71: Update SDKs
URL: https://github.com/apache/cloudstack-terraform-provider/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
CodeBleu commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1947788692
If there is going to be SDK updates, why not just go to the [Terraform
Plugin
Framework](https://developer.hashicorp.com/terraform/plugin/framework/migrating)
instead
poddm commented on PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1830638315
resolves https://github.com/apache/cloudstack-terraform-provider/issues/66
--
This is an automated message from the Apache Git Service.
To respond to the message, please
49 matches
Mail list logo
