> On 05-Feb-2015, at 7:32 pm, sebgoa wrote:
>
> We should always wait for TravisCI to finish, even for a typo.
The other issue is TravisCI on master branch is timing out which I’ll see
tomorrow or will check next to next week (entire next week is holidays for me)
if no one fixes it.
Regards,
On Feb 5, 2015, at 1:48 PM, Rohit Yadav wrote:
> Hey Sebastien - I merged it only after Erik fixed the DateTime issue
> using Joda. Changes look good to me so I did not wait for TravisCI.
I love you man, but I think that's bad practice :)
We should always wait for TravisCI to finish, even for a
Hey Sebastien - I merged it only after Erik fixed the DateTime issue
using Joda. Changes look good to me so I did not wait for TravisCI.
On Thursday 05 February 2015 06:01 PM, sebgoa wrote:
On Feb 5, 2015, at 1:26 PM, Erik Weber wrote:
I did update it Sebastien :-)
Ah my bad then (cc @Ro
On Feb 5, 2015, at 1:26 PM, Erik Weber wrote:
> I did update it Sebastien :-)
>
Ah my bad then (cc @Rohit), I did not see a conversation update about it.
all is good then :)
> --
> Erik
>
> On Thu, Feb 5, 2015 at 1:16 PM, sebgoa wrote:
>
>> Rohit, check the review, Rajani made a suggesti
I did update it Sebastien :-)
--
Erik
On Thu, Feb 5, 2015 at 1:16 PM, sebgoa wrote:
> Rohit, check the review, Rajani made a suggestion and Terbolous is going
> to change his commit.
> Please revert and let's wait for an updated commit.
>
>
> On Feb 5, 2015, at 12:54 PM, bhaisaab wrote:
>
> >
Rohit, check the review, Rajani made a suggestion and Terbolous is going to
change his commit.
Please revert and let's wait for an updated commit.
On Feb 5, 2015, at 12:54 PM, bhaisaab wrote:
> Github user bhaisaab commented on the pull request:
>
>https://github.com/apache/cloudstack/pul