RE: marvin master changes in 4.4-forward

2014-05-28 Thread Santhosh Edukulla
From: Daan Hoogland [daan.hoogl...@gmail.com] Sent: Tuesday, May 27, 2014 5:32 PM To: dev Subject: Re: marvin master changes in 4.4-forward I share that last concern. I have seen a lot of commits on the branch not matched by cherry-pick requests. On Tue

Re: marvin master changes in 4.4-forward

2014-05-27 Thread Daan Hoogland
I share that last concern. I have seen a lot of commits on the branch not matched by cherry-pick requests. On Tue, May 27, 2014 at 11:16 PM, Marcus wrote: > My impression was that we should change as little as possible once a > release is cut. We fix bugs, but we don't change code just to make it

Re: marvin master changes in 4.4-forward

2014-05-27 Thread Marcus
My impression was that we should change as little as possible once a release is cut. We fix bugs, but we don't change code just to make it more maintainable, for fear of introducing more bugs or regressing the known state of the release. That aside, this fix is fairly minor so I'll probably just d

Re: marvin master changes in 4.4-forward

2014-05-27 Thread Daan Hoogland
Marcus, I don't see why only fixes should go in 4.4. It should have been announced before feature freeze but there might be good reasons to refactor if it improves maintainability or removes bugs. You can revert the related commit and apply yours. or mix them. regards