ttps://issues.apache.org/jira/browse/CLOUDSTACK-6965.
>>
>> Regards,
>> Anshul
>>
>> -Original Message-
>> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> Sent: Wednesday, June 18, 2014 10:19 PM
>> To: dev@cloudstack.apache.org
>> S
g...@citrix.com ]
> Sent: Friday, June 20, 2014 3:32 PM
> To: dev@cloudstack.apache.org
> Subject: RE: ZoneWideStoragePoolAllocator#filter seems weird for me
>
> This patch has introduced the NullPointerException in code. Since
> ZoneWideStoragePoolAllocator's filt
dfire.com]
Sent: Wednesday, June 18, 2014 10:19 PM
To: dev@cloudstack.apache.org
Subject: Re: ZoneWideStoragePoolAllocator#filter seems weird for me
Sounds good - thanks!
On Wed, Jun 18, 2014 at 10:46 AM, Yoshikazu Nojima wrote:
> Mike,
>
> Thank you for your review.
> This is a patch I wo
014 10:19 PM
To: dev@cloudstack.apache.org
Subject: Re: ZoneWideStoragePoolAllocator#filter seems weird for me
Sounds good - thanks!
On Wed, Jun 18, 2014 at 10:46 AM, Yoshikazu Nojima wrote:
> Mike,
>
> Thank you for your review.
> This is a patch I would like to push.
> I don&#x
Sounds good - thanks!
On Wed, Jun 18, 2014 at 10:46 AM, Yoshikazu Nojima wrote:
> Mike,
>
> Thank you for your review.
> This is a patch I would like to push.
> I don't have anything to add regarding this issue.
> I will push this patch in the next few hours.
>
> Regards,
> Noji
>
>
>
>
> 2014-
Mike,
Thank you for your review.
This is a patch I would like to push.
I don't have anything to add regarding this issue.
I will push this patch in the next few hours.
Regards,
Noji
2014-06-18 9:15 GMT-06:00 Mike Tutkowski :
> Sorry...I didn't see until later in my e-mail that you had submitt
Sorry...I didn't see until later in my e-mail that you had submitted code.
It looks good to me.
Is this something you'd like checked in right away or are you planning to
add to this patch?
Thanks!
On Wed, Jun 18, 2014 at 9:06 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:
> Yeah, s
Yeah, storagePoolHasEnoughIops returns true in the traditional case (i.e.
non-managed storage) so we won't skip a storage pool when IOPS are not
really being taken into consideration.
Feel free to make enhancements and I can review your patch.
Thanks!
On Wed, Jun 18, 2014 at 12:14 AM, Yoshikazu
Prachi, Mike,
I appreciate your comments.
I think it is a bug that there is a difference between filter logic of
ClusterScopeStoragePoolAllocator and that of
ZoneWideStoragePoolAllocator
(ex. allocator skip iSCSI type storage pool or not when a volume is a RootDisk),
I will unify by implementing i
I can comment on the IOPS part.
The IOPS are currently only relevant when using managed storage (which is
currently only applicable at the zone level). That being the case, no
cluster (or local) storage takes advantage of counting IOPS that have been
handed out.
Of course this logic might be expa
>Why ZoneWideStoragePoolAllocator implements "filter" method (and doesn't call
>that of base class) rather than just using that of base class?
>ZoneWideStoragePoolAllocator#filter method seems doesn't care "avoid"
>parameter, doesn't skip iSCSI type storage pool even if a volume is a RootDisk.
T
11 matches
Mail list logo
