Re: Review Request 11942: ProcessUtil cleanup

2013-08-14 Thread Laszlo Hornyak
> On Aug. 14, 2013, 7:48 a.m., Wei Zhou wrote: > > An issue related to this patch: > > https://issues.apache.org/jira/browse/CLOUDSTACK-4314 > > and patch: > > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eb59c3c > > Testing ok on devcloud. indeed I did not test with the environm

Re: Review Request 11942: ProcessUtil cleanup

2013-08-14 Thread Wei Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11942/#review25127 --- An issue related to this patch: https://issues.apache.org/jira/brow

RE: Review Request 11942: ProcessUtil cleanup

2013-08-12 Thread Frank Zhang
@cloudstack.apache.org; John Burwell > > Cc: Laszlo Hornyak > > Subject: RE: Review Request 11942: ProcessUtil cleanup > > > > We should keep it for master > > > > > -Original Message- > > > From: Frank Zhang > > > Sent: Monday, August 12,

RE: Review Request 11942: ProcessUtil cleanup

2013-08-12 Thread Animesh Chaturvedi
rnyak > Subject: RE: Review Request 11942: ProcessUtil cleanup > > We should keep it for master > > > -Original Message- > > From: Frank Zhang > > Sent: Monday, August 12, 2013 5:40 PM > > To: Animesh Chaturvedi; dev@cloudstack.apache.org; John Burwell >

RE: Review Request 11942: ProcessUtil cleanup

2013-08-12 Thread Animesh Chaturvedi
We should keep it for master > -Original Message- > From: Frank Zhang > Sent: Monday, August 12, 2013 5:40 PM > To: Animesh Chaturvedi; dev@cloudstack.apache.org; John Burwell > Cc: Laszlo Hornyak > Subject: RE: Review Request 11942: ProcessUtil cleanup > >

RE: Review Request 11942: ProcessUtil cleanup

2013-08-12 Thread Frank Zhang
pache.org; Frank Zhang; John Burwell > Cc: Laszlo Hornyak > Subject: RE: Review Request 11942: ProcessUtil cleanup > > Is this really needed for 4.2? 4.2 is in limited updates and only > blocker/critical > bug fixes and doc and test updates are allowed. All commit

RE: Review Request 11942: ProcessUtil cleanup

2013-08-12 Thread Animesh Chaturvedi
gt; Zhang > Sent: Monday, August 12, 2013 2:43 PM > To: John Burwell; Frank Zhang > Cc: Laszlo Hornyak; cloudstack > Subject: Re: Review Request 11942: ProcessUtil cleanup > > > --- > This is an automatically generated

Re: Review Request 11942: ProcessUtil cleanup

2013-08-12 Thread John Burwell
Laszlo, I was only concerned about the lack of asserts in the original test case. That has been updated, so it looks good to me now. Thanks, -John On Aug 12, 2013, at 5:43 PM, "Frank Zhang" wrote: > > --- > This is an automatically gen

Re: Review Request 11942: ProcessUtil cleanup

2013-08-12 Thread Frank Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11942/#review25036 --- Ship it! This is very straightforward patch. Java filesystem api is

Re: Review Request 11942: ProcessUtil cleanup

2013-08-12 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11942/#review25005 --- Hi Reviewers, Any feedback on this patch? :) - Laszlo Hornyak

Re: Review Request 11942: ProcessUtil cleanup

2013-07-23 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11942/ --- (Updated July 24, 2013, 4:42 a.m.) Review request for cloudstack, Frank Zhang a

Re: Review Request 11942: ProcessUtil cleanup

2013-07-22 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11942/#review23615 --- Review 11942 PASSED the build test The url of build cloudstack-maste

Re: Review Request 11942: ProcessUtil cleanup

2013-07-20 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11942/ --- (Updated July 20, 2013, 8:01 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 11942: ProcessUtil cleanup

2013-07-04 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11942/ --- (Updated July 4, 2013, 9:34 p.m.) Review request for cloudstack. Changes

Re: Review Request 11942: ProcessUtil cleanup

2013-07-04 Thread Laszlo Hornyak
> On July 1, 2013, 3:04 p.m., John Burwell wrote: > > utils/test/com/cloud/utils/ProcessUtilTest.java, line 34 > > > > > > Is there no system state on which to assert? What would cause this > > test to fail? This tes

Re: Review Request 11942: ProcessUtil cleanup

2013-07-01 Thread John Burwell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11942/#review22599 --- utils/test/com/cloud/utils/ProcessUtilTest.java

Re: Review Request 11942: ProcessUtil cleanup

2013-06-29 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11942/ --- (Updated June 29, 2013, 3:51 p.m.) Review request for cloudstack. Changes ---