RE: Reformatting UI code

2013-07-23 Thread Animesh Chaturvedi
> -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Tuesday, July 23, 2013 9:36 AM > To: dev@cloudstack.apache.org > Cc: Jessica Wang; Brian Federle; Pranav Saxena; Ian Duffy > (i...@ianduffy.ie) > Subject: Re: Reformatting UI cod

Re: Reformatting UI code

2013-07-23 Thread Mike Tutkowski
--Original Message- > > From: Chip Childers [mailto:chip.child...@sungard.com] > > Sent: Tuesday, July 23, 2013 9:36 AM > > To: dev@cloudstack.apache.org > > Cc: Jessica Wang; Brian Federle; Pranav Saxena; Ian Duffy > > (i...@ianduffy.ie) > > Subject: Re: Refo

Re: Reformatting UI code

2013-07-23 Thread David Nalley
On Tue, Jul 23, 2013 at 12:36 PM, Chip Childers wrote: > On Tue, Jul 23, 2013 at 09:37:26AM -0600, Mike Tutkowski wrote: >> One other thought here is that we might want to wait until, say, the day >> after code freeze - if allowable - and then check in these kinds of changes >> (basically give the

Re: Reformatting UI code

2013-07-23 Thread Chip Childers
> > > > > > > > Jessica > > > > > > -Original Message- > > > From: Sebastien Goasguen [mailto:run...@gmail.com] > > > Sent: Monday, July 22, 2013 3:53 PM > > > To: Brian Federle > > > Cc: Jessica Wang; Pranav Sax

Re: Reformatting UI code

2013-07-23 Thread Mike Tutkowski
rs. > > thanks, > > > > > Jessica > > > > -Original Message- > > From: Sebastien Goasguen [mailto:run...@gmail.com] > > Sent: Monday, July 22, 2013 3:53 PM > > To: Brian Federle > > Cc: Jessica Wang; Pranav Saxena; Ian Duffy (i...@i

Re: Reformatting UI code

2013-07-23 Thread Sebastien Goasguen
; Cc: Jessica Wang; Pranav Saxena; Ian Duffy (i...@ianduffy.ie); > dev@cloudstack.apache.org > Subject: Re: Reformatting UI code > > > > On 23 Jul 2013, at 00:34, Brian Federle wrote: > >> In this case it was fine, I could resolve the conflicts by git's >&g

Re: Reformatting UI code

2013-07-22 Thread Ian Duffy
- >> From: Sebastien Goasguen [mailto:run...@gmail.com] >> Sent: Monday, July 22, 2013 3:26 PM >> To: Jessica Wang >> Cc: Pranav Saxena; Ian Duffy (i...@ianduffy.ie); dev@cloudstack.apache.org; >> Brian Federle >> Subject: Re: Reformatting UI code >> >>

RE: Reformatting UI code

2013-07-22 Thread Jessica Wang
l.com] Sent: Monday, July 22, 2013 3:53 PM To: Brian Federle Cc: Jessica Wang; Pranav Saxena; Ian Duffy (i...@ianduffy.ie); dev@cloudstack.apache.org Subject: Re: Reformatting UI code On 23 Jul 2013, at 00:34, Brian Federle wrote: > In this case it was fine, I could resolve the conflicts

Re: Reformatting UI code

2013-07-22 Thread Sebastien Goasguen
(i...@ianduffy.ie); dev@cloudstack.apache.org; > Brian Federle > Subject: Re: Reformatting UI code > > Hi jessica, > > Sorry this is causing you trouble. Ian us developing his ldap plugin in a > feature branch . > This was a UI cosmetic code change, i saw that pranav shipped

RE: Reformatting UI code

2013-07-22 Thread Brian Federle
a problem with the new formatting conventions, so no need to revert in this case. -Brian -Original Message- From: Brian Federle Sent: Monday, July 22, 2013 3:34 PM To: 'Sebastien Goasguen'; Jessica Wang Cc: Pranav Saxena; Ian Duffy (i...@ianduffy.ie); dev@cloudstack.apache.org Sub

RE: Reformatting UI code

2013-07-22 Thread Brian Federle
y 22, 2013 3:26 PM To: Jessica Wang Cc: Pranav Saxena; Ian Duffy (i...@ianduffy.ie); dev@cloudstack.apache.org; Brian Federle Subject: Re: Reformatting UI code Hi jessica, Sorry this is causing you trouble. Ian us developing his ldap plugin in a feature branch . This was a UI cosmetic code cha

Re: Reformatting UI code

2013-07-22 Thread Sebastien Goasguen
lto:psb...@gmail.com] > Sent: Monday, July 22, 2013 12:18 PM > To: dev@cloudstack.apache.org; Brian Federle > Cc: Ian Duffy (i...@ianduffy.ie) > Subject: Re: Reformatting UI code > > Hey Brian, > > Sorry to hear that it caused merge conflicts for you . But Ian did bring it

RE: Reformatting UI code

2013-07-22 Thread Jessica Wang
dev@cloudstack.apache.org; Brian Federle Cc: Ian Duffy (i...@ianduffy.ie) Subject: Re: Reformatting UI code Hey Brian, Sorry to hear that it caused merge conflicts for you . But Ian did bring it up on the mailing list and I suggested him to use the js beautifier tool for reformatting the js code w

Re: Reformatting UI code

2013-07-22 Thread Pranav Saxena
Hey Brian, Sorry to hear that it caused merge conflicts for you . But Ian did bring it up on the mailing list and I suggested him to use the js beautifier tool for reformatting the js code which I guess you missed probably because of the "heavy" traffic on the dev list and thereafter Sebastien mer

RE: Reformatting UI code

2013-07-22 Thread Jessica Wang
+1 -Original Message- From: Brian Federle [mailto:brian.fede...@citrix.com] Sent: Monday, July 22, 2013 11:33 AM To: dev@cloudstack.apache.org Cc: Ian Duffy (i...@ianduffy.ie) Subject: Reformatting UI code Hello, Recently I discovered that all JS and UI code have been reformatted to 4 s