Re: Marvin refactoring

2013-12-13 Thread sebgoa
On Dec 12, 2013, at 8:36 PM, Santhosh Edukulla wrote: > Sebastian\Team, > > Few notes. > > 1. The whole exercise is to bring quality and make Marvin "little" cleaner > where ever possible. If we see earlier\currently, at some places we followed > some convention, say to use proper casing fo

Re: Marvin refactoring

2013-12-12 Thread Prasanna Santhanam
On Wed, Dec 11, 2013 at 10:12:26AM +0100, sebgoa wrote: > > We should also have an open discussion about the import of > https://github.com/vogxn/cloud-autodeploy in > marvin/marvin/misc/build. That repo from prasanna while part of the > CI infra is really custom config for Citrix internal infra (

RE: Marvin refactoring

2013-12-12 Thread Santhosh Edukulla
Sebastian\Team, Few notes. 1. The whole exercise is to bring quality and make Marvin "little" cleaner where ever possible. If we see earlier\currently, at some places we followed some convention, say to use proper casing for class names and modules and at some places we break from this, some t

RE: Marvin refactoring

2013-12-11 Thread Animesh Chaturvedi
+1 -Original Message- From: sebgoa [mailto:run...@gmail.com] Sent: Wednesday, December 11, 2013 1:12 AM To: Santhosh Edukulla; gir...@clogeny.com; dev@cloudstack.apache.org Cc: Prasanna Santhanam Subject: Marvin refactoring Hi devs and Santosh and Girish, I am looking at Marvin lately a

RE: Marvin refactoring

2013-12-11 Thread Rayees Namathponnan
: dev@cloudstack.apache.org; Santhosh Edukulla; gir...@clogeny.com Cc: Prasanna Santhanam Subject: RE: Marvin refactoring +1 for running on separate branch before check in -Original Message- From: sebgoa [mailto:run...@gmail.com] Sent: Wednesday, December 11, 2013 1:12 AM To: Santhosh

RE: Marvin refactoring

2013-12-11 Thread Sudha Ponnaganti
+1 for running on separate branch before check in -Original Message- From: sebgoa [mailto:run...@gmail.com] Sent: Wednesday, December 11, 2013 1:12 AM To: Santhosh Edukulla; gir...@clogeny.com; dev@cloudstack.apache.org Cc: Prasanna Santhanam Subject: Marvin refactoring Hi devs and Santo