Re: [PROPOSAL] Closing PRs older than 1 month and without activity

2015-08-18 Thread Rohit Yadav
-0 I think there is no harm in keeping the PRs open which are not merged yet, as a reference which can be picked up by someone over time and merged/closed later. For example, here is an interesting PR that is more than a month old but if you close it we risk forgetting about it: https://github

Re: [PROPOSAL] Closing PRs older than 1 month and without activity

2015-08-18 Thread Remi Bergsma
Hi all, This PR includes the ones we can close now: https://github.com/apache/cloudstack/pull/706 Any LGTM’s so we can merge it? Thanks, Remi On 17 Aug 2015, at 18:56, Rajani Karuturi mailto:raj...@apache.org>> wrote: +1 for auto closing. I also agree with Boris that we need to distinguish d

Re: [PROPOSAL] Closing PRs older than 1 month and without activity

2015-08-17 Thread Remi Bergsma
Hi Rajani, If we truly “merge” PRs, which I think we should do (instead of applying a patch) then those will be in state “Merged” (purple) versus “Closed” (red). Regards, Remi On 17 Aug 2015, at 18:56, Rajani Karuturi mailto:raj...@apache.org>> wrote: +1 for auto closing. I also agree with B

Re: [PROPOSAL] Closing PRs older than 1 month and without activity

2015-08-17 Thread Remi Bergsma
Hi Boris, I like the idea, but this is a bit harder than it seems. We only have read-only access to GitHub, because it is a mirror of the actual git repo at Apache. That’s why we cannot simply close PRs etc. For the same reason, I cannot create labels or assign them. Not even for the PRs I subm

Re: [PROPOSAL] Closing PRs older than 1 month and without activity

2015-08-17 Thread Rajani Karuturi
+1 for auto closing. I also agree with Boris that we need to distinguish discarded vs. Merged prs. On Mon, Aug 17, 2015 at 21:51 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: +1 Sounds reasonable On Mon, Aug 17, 2015 at 8:25 AM, Remi Bergsma > wrote: > Hi all, > > There are several

Re: [PROPOSAL] Closing PRs older than 1 month and without activity

2015-08-17 Thread Mike Tutkowski
+1 Sounds reasonable On Mon, Aug 17, 2015 at 8:25 AM, Remi Bergsma wrote: > Hi all, > > There are several PRs that are quite old. They haven't been updated by > their author for over a month and there was no response to comments made. > > As a RM, I want to maintain an as-short-as-possible list

RE: [PROPOSAL] Closing PRs older than 1 month and without activity

2015-08-17 Thread Somesh Naidu
+1 Regards, Somesh -Original Message- From: Remi Bergsma [mailto:rberg...@schubergphilis.com] Sent: Monday, August 17, 2015 10:26 AM To: dev@cloudstack.apache.org Subject: [PROPOSAL] Closing PRs older than 1 month and without activity Hi all, There are several PRs that are quite old.

RE: [PROPOSAL] Closing PRs older than 1 month and without activity

2015-08-17 Thread Boris Schrijver
Remi, Would it be possible to give the closed PRs which are not merged due to inactivity or unfinished code-work a label? So the can be recognized when they are closed? Best regards, Boris Schrijver TEL: +31633784542 MAIL: bo...@pcextreme.nl > > On August 17, 2015 at 5:49 PM Somesh Naidu