Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-09 Thread Kelven Yang
+1 Kelven On 10/9/13 9:18 AM, "Chip Childers" wrote: >+1 from me too. > > >On Wed, Oct 9, 2013 at 12:13 PM, Prasanna Santhanam >wrote: > >> Here's the BVT result from spring-modularization branch: Failures that >> are listed exist on master as well. So the branch doesn't break >> anything add

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-09 Thread Chip Childers
+1 from me too. On Wed, Oct 9, 2013 at 12:13 PM, Prasanna Santhanam wrote: > Here's the BVT result from spring-modularization branch: Failures that > are listed exist on master as well. So the branch doesn't break > anything additionally. > > +1 to merge > > http://jenkins.buildacloud.org/job/t

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-09 Thread Prasanna Santhanam
Here's the BVT result from spring-modularization branch: Failures that are listed exist on master as well. So the branch doesn't break anything additionally. +1 to merge http://jenkins.buildacloud.org/job/test-matrix/571/ Xen: Test Run: #892 Logs: http://jenkins.buildacloud.org/job/test-matrix/

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-09 Thread Prasanna Santhanam
On Tue, Oct 08, 2013 at 10:20:01AM -0700, Darren Shepherd wrote: > >From what I can gather it seems that master currently fails the BVT > (and know when I say BVT I mean that black box that apparently exists > somewhere doing something, but I have no clue what it really means). > So in turn my spri

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-08 Thread Chiradeep Vittal
I'm personally +1. Simulator seems to work On 10/8/13 3:12 PM, "Darren Shepherd" wrote: >So what's the verdict? What would it take for everyone to feel warm >and fuzzy about this merge, given the troubled past this community has >had with Spring. I'm not saying the code is perfect, but so far

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-08 Thread Darren Shepherd
So what's the verdict? What would it take for everyone to feel warm and fuzzy about this merge, given the troubled past this community has had with Spring. I'm not saying the code is perfect, but so far its not terribly bad :) Darren On Tue, Oct 8, 2013 at 11:10 AM, Chiradeep Vittal wrote: > I

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-08 Thread Chiradeep Vittal
I'm not getting any notifications of BVT test failures. Where do I subscribe? On 10/8/13 10:20 AM, "Darren Shepherd" wrote: >From what I can gather it seems that master currently fails the BVT >(and know when I say BVT I mean that black box that apparently exists >somewhere doing something, but

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-08 Thread Darren Shepherd
>From what I can gather it seems that master currently fails the BVT (and know when I say BVT I mean that black box that apparently exists somewhere doing something, but I have no clue what it really means). So in turn my spring modularization branch will additionally fail BVT. Citrix internal QA

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-04 Thread Darren Shepherd
; > >> nature of this I want to get this merged as fast as possible. >>> > >> >>> > >> Darren >>> > >> >>> > >> > On Oct 2, 2013, at 4:43 PM, Alex Huang wrote: >>> > >> > >>>

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-04 Thread Darren Shepherd
ure of this I want to get this merged as fast as possible. >> > >> >> > >> Darren >> > >> >> > >> > On Oct 2, 2013, at 4:43 PM, Alex Huang wrote: >> > >> > >> > >> > +1 on running the BVT on it. We've been

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-04 Thread Prasanna Santhanam
wrote: > > >> > > > >> > +1 on running the BVT on it. We've been through this one once before. > > >> > Should be careful. > > >> > > > >> > --Alex > > >> > > > >> >> -Original Message- > &

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-03 Thread Prasanna Santhanam
; > >> Darren > >> > >> > On Oct 2, 2013, at 4:43 PM, Alex Huang wrote: > >> > > >> > +1 on running the BVT on it. We've been through this one once before. > >> > Should be careful. > >> > > >> > --Alex

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-03 Thread Prasanna Santhanam
On Thu, Oct 03, 2013 at 02:46:40PM +, Rayees Namathponnan wrote: > Hi Prasanna, > > If we are running BVT or regression on specific branch, marvin > should also from same branch right ? but we always getting marvin > from master branch job "cloudstack-marvin" > Yes, but marvin's core is the

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-03 Thread Darren Shepherd
ve been through this one once before. >> > Should be careful. >> > >> > --Alex >> > >> >> -----Original Message----- >> >> From: Kelven Yang [mailto:kelven.y...@citrix.com] >> >> Sent: Wednesday, October 2, 2013 4:39 PM >>

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-03 Thread Darren Shepherd
Sure can switch jenkins.buildacloud.org to build off of spring-modularization? It will at least fix the DB upgrade issues. I really don't understand the whole test environment. What tests are ran where, how to get "BVT" running etc. Darren On Thu, Oct 3, 2013 at 7:58 AM, Chip Childers wrote: >

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-03 Thread Chip Childers
On Wed, Oct 2, 2013 at 8:59 PM, Darren Shepherd wrote: > It's actually really easy to turn this off. If you look at the last > commit of the branch you'll see what changes to turn it on. So you can > just reverse that one commit to disable it. > > I'd rather merge this and then do the BVTs on

RE: [MERGE] spring-modularization to master - Spring Modularization

2013-10-03 Thread Rayees Namathponnan
.org] Sent: Wednesday, October 02, 2013 10:06 PM To: dev@cloudstack.apache.org Subject: Re: [MERGE] spring-modularization to master - Spring Modularization I switched the test infrastructure on jenkins.buildacloud.org to run the bvts [1] against master last week. Couple of weeks before that the si

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-02 Thread Prasanna Santhanam
t; > +1 on running the BVT on it. We've been through this one once before. > > Should be careful. > > > > --Alex > > > >> -Original Message- > >> From: Kelven Yang [mailto:kelven.y...@citrix.com] > >> Sent: Wednesday, October 2, 20

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-02 Thread Kelven Yang
On 10/2/13 5:52 PM, "Darren Shepherd" wrote: >Kelvin, > >Also since I'm using dynamic proxies for AOP, spring is suppose to expose >all interface of the target. But I'll still dig in and make sure 100% >this is all good. > >Darren > >> On Oct 2, 2013, at 5:40 PM, Darren Shepherd >> wrote: >>

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-02 Thread Darren Shepherd
We've been through this one once before. >> Should be careful. >> >> --Alex >> >>> -Original Message- >>> From: Kelven Yang [mailto:kelven.y...@citrix.com] >>> Sent: Wednesday, October 2, 2013 4:39 PM >>> To: dev@cloudstack.apache.or

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-02 Thread Darren Shepherd
Kelvin, Also since I'm using dynamic proxies for AOP, spring is suppose to expose all interface of the target. But I'll still dig in and make sure 100% this is all good. Darren > On Oct 2, 2013, at 5:40 PM, Darren Shepherd > wrote: > > I know the majority of the polymorphic stuff is work

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-02 Thread Darren Shepherd
the BVT on it. We've been through this one once before. > Should be careful. > > --Alex > >> -Original Message- >> From: Kelven Yang [mailto:kelven.y...@citrix.com] >> Sent: Wednesday, October 2, 2013 4:39 PM >> To: dev@cloudstack.apache.org >>

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-02 Thread Darren Shepherd
I know the majority of the polymorphic stuff is working fine right now. But now that you bring it up I'm kinda wondering why. It very we'll be possible that the way in which I'm discovering extensible types precludes it from AOP matching the beans. (Which isn't bad. We should only use AOP

RE: [MERGE] spring-modularization to master - Spring Modularization

2013-10-02 Thread Alex Huang
: Re: [MERGE] spring-modularization to master - Spring > Modularization > > Darren, > > This looks really nice. A few questions on Spring AOP replacement. > > 1) Spring AOP is proxy-based, the reason we ended up of using customized > AOP is mainly due to that inside existing CloudSt

Re: [MERGE] spring-modularization to master - Spring Modularization

2013-10-02 Thread Kelven Yang
Darren, This looks really nice. A few questions on Spring AOP replacement. 1) Spring AOP is proxy-based, the reason we ended up of using customized AOP is mainly due to that inside existing CloudStack codebase, we have many places that are doing run-time type-casting, the code in these places ass