Top posting on this one to reinforce a few things:
Master is now our release branch
Merge on master by the RMs *only*
PR still need 2 LGTM
Do note, that any committer is free to create any other branch and work there
or work on their own fork.
The goal is not to slow down development but instea
On 12/14/2015 11:15 PM, Remi Bergsma wrote:
> Guys,
>
> I can see Daan fixed the build and am happy he cares so much about that. But
> I don't see why we had to do it like this, instead of reverting the PR that
> caused the build to fail? That's something one can do quickly without review.
>
Guys,
I can see Daan fixed the build and am happy he cares so much about that. But I
don't see why we had to do it like this, instead of reverting the PR that
caused the build to fail? That's something one can do quickly without review.
Now the mess is complete. A broken PR merged (can happen)
Guys,
I can see Daan fixed the build and am happy he cares so much about that. But I
don't see why we had to do it like this, instead of reverting the PR that
caused the build to fail? That's something one can do quickly without review.
Now the mess is complete. A broken PR merged (can happen)
You have been doing this blindly and I don't accept this
I have applied the mentioned code directly to master. Next time first see
if you can add your lgtm and whether the code is needed.
On Mon, Dec 14, 2015 at 4:58 PM, Boris Schrijver wrote:
> Hi all,
>
> Just to make this clear once more. A P
Hi all,
Just to make this clear once more. A PR needs two LGTM's. One of them needs to
run the integration- and unit-tests. While the other does code review.
This is a the minimal requirement. More is always welcome, anything less will be
reverted.
I just enforced this policy [1]. Any active com
