Re: Network.{Provider,Service,Capability} string names don't match constant names

2013-09-27 Thread Darren Shepherd
I created https://reviews.apache.org/r/14360/ for this. I found that changing the provider names would be rather impactful, but changing the Capability and Service didn't seem to matter. I can't find any reference to the string constant names anywhere. The unit test I added will ensure that futu

Network.{Provider,Service,Capability} string names don't match constant names

2013-09-27 Thread Darren Shepherd
For Network.{Provider,Service,Capability} the getName() does not always match the constant names. For example Capability.SupportedVpnProtocols, the getName() is "SupportedVpnTypes". For Capability.SupportedLBAlgorithms the getName() is "SupportedLbAlgorithms". Can we just clean up all those cons