Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Correct header for CommandCreationWorker
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by Alena. Most of the changes are the
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Problems updating previous patch
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by Alena. Most of the changes are the same
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Resolve conflicts with master.
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by Alena. Most of the changes are the same, but
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Fix conflicts with last master
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by Alena. Most of the changes are the same, but
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Fix conflicts due to last master changes. Plus improving a couple of names.
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by
: [master]~/repos/dr/cloudstack$ git am --signoff <
~/Desktop/0001-Dispatcher-corrections-refactoring-and-tests.patch
Applying: Dispatcher corrections, refactoring and tests
error: patch failed: server/src/com/cloud/api/ApiServer.java:881
error: server/src/com/cloud/api/ApiServer.java: patch does
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
CallContext.current().setEventDisplayEnabled(cmd.isDisplayResourceEnabled());
should be called after the dispatch chain
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
New BaseCmd#getActualCommandName plus resolving new conflict with recent commits
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were
>>
>> - Alena Prokharchyk
>>
>> On March 4th, 2014, 12:18 a.m. UTC, Antonio Fornie wrote:
>> Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and
>> Hugo Trippaers.
>> By Antonio Fornie.
>>
>> *Updated March 4, 2014, 12:18 a
a Prokharchyk, daan Hoogland, and
> Hugo Trippaers.
> By Antonio Fornie.
>
> *Updated March 4, 2014, 12:18 a.m.*
> *Repository: * cloudstack-git
> Description
>
> Dispatcher corrections, refactoring and tests. Corrects problems from
> previous attempts that were reverted by A
.org/r/17888/
> ---
>
> (Updated March 4, 2014, 12:18 a.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo
> Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Dispatcher corrections, refactoring
h 3, 2014, 11:26 p.m.*
> *Repository: * cloudstack-git
> Description
>
> Dispatcher corrections, refactoring and tests. Corrects problems from
> previous attempts that were reverted by Alena. Most of the changes are the
> same, but this one is not creating conflicts of Map types for Ayn
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Fix compilation problem
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by Alena. Most of the changes are the same, but
this
che.org/r/17888/
> ---
>
> (Updated March 3, 2014, 11:26 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo
> Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Dispat
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Resolved conflicts with latest master
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by Alena. Most of the changes are the
issue with
AutoScaleManagerImpl. Should be a quick fix from your side?
Applying: Dispatcher corrections, refactoring and tests.
error: patch failed:
server/src/com/cloud/network/as/AutoScaleManagerImpl.java:448
error: server/src/com/cloud/network/as/AutoScaleManagerImpl.java: patch does
not apply
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by Alena. Most of the changes are the same, but
this one is not creating conflicts of Map types for Aync Commands or for
parameters as Lists or Maps.
Diffs (updated)
-
api/src
gt;
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Dispatcher corrections, refactoring and tests. Corrects problems from
> previous attempts that were reverted by Alena. Most of the changes are the
> same, but this one is not creating conflicts of Map types for
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Fixed a conflict with head master
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by Alena. Most of the changes are the same
t;
> >Exceptions are apart from the subject, because I never return false to
> >avoid throwing an exception (actually I never return false at all but I
> >design it to be open).
> >
> >* change the return type to void. I'm pretty sure the developers writing
> >>
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Thanks for the comments. I include changes for each one of them: 1) null inits,
2) Inject(), 3) no boolean based way to stop dispatch chain, 4) class name got
dynamically.
Repository: cloudstack-git
Description
---
Dispatcher
would not pass the review :) And further he
>would
>read the javadoc header
> * @return false to stop the chain of responsibility, true
> * to continue the chain with the next worker
>
>...nothing mentions that false means error.
>
>
>
>
>> Whatever
and if you don't mind I will request your review
for future related patches. Can you confirm what other things you finally
want me to change in addition to this?
Thank you very much again.
Antonio
> Let me know what you think,
> -Alena.
>
> From: Antonio Fornié Casarrubios
>
;>
Cc: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>"
mailto:dev@cloudstack.apache.org>>, daan Hoogland
mailto:daan.hoogl...@gmail.com>>, Hugo Trippaers
mailto:htrippa...@schubergphilis.com>>
Subject: Re: Review Request 17888: Dispatcher corre
e use polymorphism. For this
I created the SemanticValidationWorker so that there the work is actually
delegated to the Cmd class (polymorphism)
>
> >
> >>
> >> 4) I can see that you do a lot of initialization like that for private
> >>variables:
> >>
al variables are not initialized, but instance ones
>are
>(booleans to false, numbers to cero, objects to null...). But I find it
>more clear to put it this way, further people may ignore or forget it,
>specially non Java people helping in cloudstack. It's also something I've
>
re the patch is accepted, I can change
that too.*
*Upon reception of your comments I will change and upload anything.*
- Alena Prokharchyk
>
> On February 26th, 2014, 9:12 a.m. UTC, Antonio Fornie wrote:
> Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and
> Hugo Tr
>
> (Updated Feb. 26, 2014, 9:12 a.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo
> Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Dispatcher corre
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Fix based on last comments. Mainly adding signature and apikey to the geeric
expected params.
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts
kharchyk
>>
>> On February 25th, 2014, 12:11 p.m. UTC, Antonio Fornie wrote:
>> Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and
>> Hugo Trippaers.
>> By Antonio Fornie.
>>
>> *Updated Feb. 25, 2014, 12:11 p.m.*
>> *Reposito
eb. 25, 2014, 12:11 p.m.*
> *Repository: * cloudstack-git
> Description
>
> Dispatcher corrections, refactoring and tests. Corrects problems from
> previous attempts that were reverted by Alena. Most of the changes are the
> same, but this one is not creating conflicts of Map types for
gt; Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Dispatcher corrections, refactoring and tests. Corrects problems from
> previous attempts that were reverted by Alena. Most of the changes are the
> same, but this one is not creatin
t;
> (Updated Feb. 25, 2014, 12:11 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo
> Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Dispatcher corrections, refactoring and tests. C
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Just to resolve the conflict with current master
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by Alena. Most of the
].key=region&tags[0].value=canada
Also other examples like
http://localhost:8096/client/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire
Repository: cloudstack-git
Descrip
Prokharchyk, daan Hoogland, and Hugo
Trippaers.
Changes
---
Just rebase the changes with all these last commit so that when the patch is
finally pushed there are no conflicts.
Repository: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by Alena. Most of the changes are the same, but
this one is not creating conflicts of Map types for Aync Commands or for
parameters as Lists or Maps.
Diffs
-
api/src/org/apache
: cloudstack-git
Description
---
Dispatcher corrections, refactoring and tests. Corrects problems from previous
attempts that were reverted by Alena. Most of the changes are the same, but
this one is not creating conflicts of Map types for Aync Commands or for
parameters as Lists or Maps
aisal Azizullah" wrote:
>Hi,
>
>Can some one point me to the documentation/source code of Dispatcher in
>cloud stack .
>
>Thanks,
>
>Faisal
VM, how this job is handled.
>
> Thanks,
>
> Faisal
>
> On May 7, 2013, at 10:54 AM, Vijayendra Bhamidipati <
> vijayendra.bhamidip...@citrix.com> wrote:
>
> > Hi Faisal,
> >
> > Are you referring to the API dispatcher in cloudstack? If so, there are
&g
Thanks Vijay,
I am looking for how jobs are processed in cloudstack, let say for e.g. if I
want to create a new VM, how this job is handled.
Thanks,
Faisal
On May 7, 2013, at 10:54 AM, Vijayendra Bhamidipati
wrote:
> Hi Faisal,
>
> Are you referring to the API dispatcher in c
Hi Faisal,
Are you referring to the API dispatcher in cloudstack? If so, there are two
starting points - one for servlet requests received over 8080, and the other
for the integration port (8096 by default). The former starts with handle() in
ApiServer.java. The latter starts with doGet() and
Hi,
Can some one point me to the documentation/source code of Dispatcher in cloud
stack .
Thanks,
Faisal
43 matches
Mail list logo
