Re: Coverage Analysis: Few Issues

2013-11-15 Thread Will Stevens
I will just remove them. It appears the only reason they are there is for backwards compatibility. I have checked other plugins and they all just expose the device specific api commands (Other than SRX which exposes both). The problem with merging them into one command is the PaloAlto plugin is

Re: Coverage Analysis: Few Issues

2013-11-15 Thread Sheng Yang
Sure, if you don't need these addExternalFirewall etc., you can just remove them. Because the name of addExternalFirewall etc. is too generic, so I thought if you need them as well, you should able to merge your version and SRX version into one command. --Sheng On Fri, Nov 15, 2013 at 9:47 AM,

Re: Coverage Analysis: Few Issues

2013-11-15 Thread Will Stevens
I have looked into this briefly. It appears that these commands are not needed, so I will remove them and only keep the Palo Alto specific commands. addPaloAltoFirewall=1 deletePaloAltoFirewall=1 configurePaloAltoFirewall=1 listPaloAltoFirewalls=1 listPaloAltoFirewallNetworks=1 Cheers, Will

Re: Coverage Analysis: Few Issues

2013-11-14 Thread Will Stevens
Yes, I will look into the naming of the API commands in the Palo Alto plugin. When you say 'they are supposed to be merged as one command', what do you mean? These were the commands that I exposed. Palo Alto firewall commands addExternalFirewall=1 deleteExternalFirewall=1 listExternalFirewa

Re: Coverage Analysis: Few Issues

2013-11-14 Thread Sheng Yang
Hi Will, Could you check on Palo Alto's duplicate api commands? They suppose to be merged as one command I think. BTW, how can this works? Did it broke SRX? --Sheng On Thu, Nov 14, 2013 at 2:55 AM, Santhosh Edukulla < santhosh.eduku...@citrix.com> wrote: > Team, > > While running code coverag

Coverage Analysis: Few Issues

2013-11-14 Thread Santhosh Edukulla
Team, While running code coverage analysis with sonar for integration tests, based upon the errors thrown, i could see the below issues\notes with CS project. Issue1: The coverage tool is complaining about duplicate sources for below files. These are available with same name under folders ./