Re: Configuration variable changes...

2013-09-11 Thread Darren Shepherd
On 09/11/2013 09:40 AM, Alex Huang wrote: I can probably add a method with the exact same signature but really all it does will be check the type and cast. Yeah that's all I want. It's just so you aren't forced to do (Integer)depot.get("mynumber") because that would be an unsafe cast and

RE: Configuration variable changes...

2013-09-11 Thread Alex Huang
> Can the generic API be > >ConfigKey get(String paramName, Class type); > > Just to be a little easier to use. I know the method is discouraged, but I > do so > some places it would be useful. Besides that I like it. > The contract is simple enough that the implementation can become q

Re: Configuration variable changes...

2013-09-09 Thread Darren Shepherd
On 09/09/2013 12:41 PM, Alex Huang wrote: > The problem is the second constructor saved me a lot of typing when I convert from the enums in Config.java to using this class. You could immediately deprecate the new method :)

RE: Configuration variable changes...

2013-09-09 Thread Alex Huang
7;s a need for it, please go ahead and add another constructor. --Alex > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Monday, September 9, 2013 12:01 PM > To: dev > Subject: Re: Configuration variable changes... > > Alex, >

Re: Configuration variable changes...

2013-09-09 Thread Darren Shepherd
On 09/09/2013 10:20 AM, Alex Huang wrote: As part of the work to pull apart orchestration from self service, I made some changes to how configuration parameters work. The problem with the current system are as follows: - configuration variables are all stored as enums in Config.java which mea

Re: Configuration variable changes...

2013-09-09 Thread Daan Hoogland
Alex, I looked up the constructors and figured it out. next question is about two of them: public ConfigKey(Class type, String name, String category, String defaultValue, String description, boolean isDynamic); and public ConfigKey(String category, Class type, String name, String defaultV

Re: Configuration variable changes...

2013-09-09 Thread Daan Hoogland
Looks great Alex, One question; Adding a scope or a multiplier is featured on the wiki but not specified. Can you add a pointer to it? Very nice indeed, Daan On Mon, Sep 9, 2013 at 7:20 PM, Alex Huang wrote: > As part of the work to pull apart orchestration from self service, I made > some cha

Configuration variable changes...

2013-09-09 Thread Alex Huang
As part of the work to pull apart orchestration from self service, I made some changes to how configuration parameters work. The problem with the current system are as follows: - configuration variables are all stored as enums in Config.java which means plugins have to modify a single file. W