Backported to 4.4 branch.
-min
From: Daan Hoogland mailto:daan.hoogl...@gmail.com>>
Date: Wednesday, September 3, 2014 11:52 AM
To: dev mailto:dev@cloudstack.apache.org>>, Min Chen
mailto:min.c...@citrix.com>>
Subject: Re: Commit cd8af6a
guess you should go ahead and backpor
guess you should go ahead and backport.
On Wed, Sep 3, 2014 at 8:28 PM, Min Chen wrote:
> This is a bug that will impact reference counting only for old volume on
> NFS to S3 object store migration.
>
> Thanks
> -min
>
> On 9/3/14 11:25 AM, "Daan Hoogland" wrote:
>
> >H Min,
> >
> >what is thi
This is a bug that will impact reference counting only for old volume on
NFS to S3 object store migration.
Thanks
-min
On 9/3/14 11:25 AM, "Daan Hoogland" wrote:
>H Min,
>
>what is this fix for?
>
>
>On Wed, Sep 3, 2014 at 8:20 PM, Min Chen wrote:
>
>> Fix is checked into master branch. Can I
Fix is checked into master branch. Can I back port it to 4.4?
Thanks
-min
On 9/3/14 9:42 AM, "Min Chen" wrote:
>Thanks Hugo for pointing that out. That is a bug caused by copy-and-paste,
>the code should be in decrRefCnt routine like other SnapshotDataStoreVO
>and TemplateDataStoreVO.
>I will f
H Min,
what is this fix for?
On Wed, Sep 3, 2014 at 8:20 PM, Min Chen wrote:
> Fix is checked into master branch. Can I back port it to 4.4?
>
> Thanks
> -min
>
> On 9/3/14 9:42 AM, "Min Chen" wrote:
>
> >Thanks Hugo for pointing that out. That is a bug caused by copy-and-paste,
> >the code s
Thanks Hugo for pointing that out. That is a bug caused by copy-and-paste,
the code should be in decrRefCnt routine like other SnapshotDataStoreVO
and TemplateDataStoreVO.
I will fix this in a minute.
-min
On 9/3/14 12:30 AM, "Hugo Trippaers" wrote:
>Min,
>
>I¹m checking some findbugs reports
Min,
I’m checking some findbugs reports and found the following piece of code in
VolumeDataStoreVO (line 352):
public void setRefCnt(Long refCnt) {
if (refCnt > 0) {
refCnt--;
}
else {
s_logger.warn("We should not try to decrement a zero refere
