Re: Code quality, QA, etc

2014-02-11 Thread Amogh Vasekar
On 2/11/14 3:54 PM, "Nate Gordon" wrote: >My goal is to eventually do a full build, deploy, configure, and >automated tests against a scratch built local cloud with every commit from >selected branches or daily from master (Hooray for nested virtualization >and excess hardware) Had done someth

Re: Code quality, QA, etc

2014-02-11 Thread Nate Gordon
Sorry for being a few days late on this. I totally agree with the direction this conversation is going, but as someone who has done build engineering in various incarnations over the last couple of years, I would suggest two additional things. Build per branch and gitflow. We have had good succe

Re: Code quality, QA, etc

2014-02-07 Thread Rohit Yadav
On Fri, Feb 7, 2014 at 2:16 PM, Hugo Trippaers wrote: > Hey David, > > I would make a distinction between code issues and functional issues. > Occasionally somebody just plainly breaks the build, i'm guilty of that > myself actually, and thats just plain stupid. Luckily we have Jenkins to > cat

Re: Code quality, QA, etc

2014-02-07 Thread Jake Farrell
now. This would be a great if RM can enforce this > >> during check ins - review unit tests and results before approving a > >> check in. > >> > >> -----Original Message- > >> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Tripp

Re: Code quality, QA, etc

2014-02-07 Thread Laszlo Hornyak
Hi, I used to work with gerrit in OS projects and I think the tool is great, the integration with jenkins is cool. One problem could be when jenkins infrastructure problems are frequent and developers start to ignore warnings from jenkins. With my particular project we were also frequently hit by

Re: Code quality, QA, etc

2014-02-07 Thread Yoshikazu Nojima
this practice now. This would be a great if RM can enforce this >> during check ins - review unit tests and results before approving a >> check in. >> >> -Original Message- >> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers >> Sent:

Re: Code quality, QA, etc

2014-02-07 Thread Mike Tutkowski
ilto:trip...@gmail.com] On Behalf Of Hugo Trippaers > Sent: Friday, February 07, 2014 12:46 AM > To: dev > Cc: jfarr...@apache.org > Subject: Re: Code quality, QA, etc > > Hey David, > > I would make a distinction between code issues and functional issues. > Occasionally

RE: Code quality, QA, etc

2014-02-07 Thread Sudha Ponnaganti
this during check ins - review unit tests and results before approving a check in. -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Friday, February 07, 2014 12:46 AM To: dev Cc: jfarr...@apache.org Subject: Re: Code quality, QA, etc Hey

Re: Code quality, QA, etc

2014-02-07 Thread Hugo Trippaers
Hey David, I would make a distinction between code issues and functional issues. Occasionally somebody just plainly breaks the build, i’m guilty of that myself actually, and thats just plain stupid. Luckily we have Jenkins to catch these errors quickly. I’m in a continuous struggle with Jenkins

Code quality, QA, etc

2014-02-06 Thread David Nalley
Hi folks, We continue to break things large and small in the codebase, and after a number of different conversations; I thought I'd bring that discussion here. First - coding quality is only one factor that the PMC considers when making someone a committer. Second - CloudStack is a huge codebase