Marcus, would you mind to check in your fix into master? Thanks.
> -Original Message-
> From: SuichII, Christopher [mailto:chris.su...@netapp.com]
> Sent: Thursday, October 17, 2013 4:35 PM
> To:
> Subject: Re: CLVM broken on master
>
> I've done some test
gt;>> For CLVM, the copy template from secondary to primary and create volume
>>>> from template logic is handled by
>>>> CloudStackPrimaryDataStoreDriverImpl->copyAsync, not in
>>>> AncientDataMotionStrategy
>>>> You can check the co
led by
>>> CloudStackPrimaryDataStoreDriverImpl->copyAsync, not in
>>> AncientDataMotionStrategy
>>> You can check the code: 4fb459355337c874a10f47c0224af72d6fef1ff2.
>>>
>>>> -Original Message-
>>>> From: Marcus Sorensen [mailto:shadow...@gm
cientDataMotionStrategy
>> You can check the code: 4fb459355337c874a10f47c0224af72d6fef1ff2.
>>
>>> -Original Message-
>>> From: Marcus Sorensen [mailto:shadow...@gmail.com]
>>> Sent: Thursday, October 17, 2013 2:07 PM
>>> To: dev@clouds
Thursday, October 17, 2013 2:07 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: CLVM broken on master
>>
>> I think if we can change this line:
>>
>> if ((srcData.getObjectType() == DataObjectType.TEMPLATE) &&
>> (destData.getObjectType() == DataObjectType.
> From: Marcus Sorensen [mailto:shadow...@gmail.com]
> Sent: Thursday, October 17, 2013 2:07 PM
> To: dev@cloudstack.apache.org
> Subject: Re: CLVM broken on master
>
> I think if we can change this line:
>
> if ((srcData.getObjectType() == DataObjectType.TEMPLATE
I think if we can change this line:
if ((srcData.getObjectType() == DataObjectType.TEMPLATE) &&
(destData.getObjectType() == DataObjectType.TEMPLATE &&
destData.getDataStore().getRole() == DataStoreRole.Primary)) {
to something like:
if (srcData.getObjectType() == DataObjectType.TEMPLATE &&
srcD
I ran that through my tester, it didn't like it. That actually kept
the system vms from starting. Since CopyCommand is used for both
template to template and template to primary, it seems that the
original template copy is fine but now this catches the case where the
source template is on primary
Hm, interesting.
Since nothing else in the if/else if series there depends on the src being a
template, I'd imagine it would be safe to just have the check be:
} else if (srcData.getObjectType() == DataObjectType.TEMPLATE &&
destDataStore.getRole() == DataStoreRole.Primary) {
In hindsight, add
Actually, I don't think that will fix this (though it probably fixes
something :-)
The issue I'm having is that we went from 'if source is a template on
nfs and destination is primary storage' to 'if source is a template
and destination is a template on primary storage'. We aren't copying
'templat
Ok, let me test it.
On Thu, Oct 17, 2013 at 12:56 PM, SuichII, Christopher
wrote:
> Oh, I noticed this and created a fix, which I thought I already had submitted
> since it was a part of the storage refactoring a couple weeks back. I'll post
> the patch for review now.
>
> --
> Chris Suich
> ch
Oh, I noticed this and created a fix, which I thought I already had submitted
since it was a part of the storage refactoring a couple weeks back. I'll post
the patch for review now.
--
Chris Suich
chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Ci
Just posting this to dev for visibility.
I think commit 180cfa19 broke CLVM primary storage for KVM. I'm
failing VM deploy from template. I've been building a 'sanity check'
test that focuses on the KVM specific suff (tests storage types and
supported host OS for now), and this bubbled up.
Read m
13 matches
Mail list logo
