[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

2015-07-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/610 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

2015-07-22 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/610#issuecomment-123775323 LGTM :+1: Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

2015-07-21 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/610#issuecomment-123272585 @DaanHoogland Thanks for the information. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

2015-07-21 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/610#issuecomment-123252820 @koushik-das 'dead local storage' is a source analysis term for 'unused variable'. Not severe unless it happens a lot, because of memory consumption. --- If yo

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

2015-07-21 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/610#issuecomment-123232196 Changes look good. Not sure what "dead local store" mean. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

2015-07-20 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/610#issuecomment-123161896 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

2015-07-20 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/610 CLOUDSTACK-7539: coverity regression dead local store You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack coverity

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122246365 will do --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-17 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122246019 @karuturi @DaanHoogland @bhaisaab I suggest we merge it into 4.5 as well so that it makes 4.5.2 --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-17 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122241816 @DaanHoogland are you pushing this to 4.5 branch as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-17 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122240171 I just tested it on 4.5 management server and my deployment errors are gone. I'm fine with it. LGTM --- If your project is set up for it, you can reply to th

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122236249 figured something like that but had't noticed the wait <:} @bhaisaab @wido are you fine like with this? --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-17 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122234984 Its not always safe. http://stackoverflow.com/a/14837457/201514 In our example, the threads unnecessarily wait for 1000 ms if the previous threads exited from a

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-15640 I found documentation on the net [1] that this is fine but I changed the flow anyway [1]http://stackoverflow.com/questions/7971946/in-java-return-value-wit

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122216105 @wido, sounds like you mean to have it in but are not satisfied because of @karuturi 's remark. I will look into adding the notify at some place as I think it m

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-17 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-122210319 Since the comment of @karuturi says there is something wrong with the code I don't think we can say LGTM here? I actually encountered this issue today on a runn

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-16 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/572#discussion_r34861726 --- Diff: engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java --- @@ -216,15 +223,82 @@ public boolean sto

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-121829053 While LGTM and travis seems to be happy about it, my java kung - {locks and synchroization} -fu skills are not to be trusted --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

2015-07-09 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/572 CLOUDSTACK-7539: [S3] Parallel deployment makes reference count of a … …cache in nfs secondary staging store negative(-1) old review request by Hiroki Ohashi that is planned

CLOUDSTACK-7539

2014-10-17 Thread Francois Gaudreault
Looks like we are hitting that same problem, but with different symptoms on swift. We even see the template being pushed to secstor staging in a directory instead of a file. Any idea how to mitigate or workaround? We can deploy some templates, but not some others works once in 20. -- Francoi

Re: Review Request 26263: CLOUDSTACK-7539: [S3] Parallel deployment makes reference count of a cache in nfs secondary staging store negative(-1)

2014-10-10 Thread Hiroki Ohashi
enerated e-mail. To reply, visit: > https://reviews.apache.org/r/26263/ > --- > > (Updated Oct. 3, 2014, 5:54 p.m.) > > > Review request for cloudstack, edison su and Min Chen. > > > Bugs: CLOUDSTACK-7539 > https://issues.apache.org/jira/browse/CLOUDSTACK-7539 &

Re: Review Request 26263: CLOUDSTACK-7539: [S3] Parallel deployment makes reference count of a cache in nfs secondary staging store negative(-1)

2014-10-08 Thread Rohit Yadav
> (Updated Oct. 3, 2014, 8:54 a.m.) > > > Review request for cloudstack, edison su and Min Chen. > > > Bugs: CLOUDSTACK-7539 > https://issues.apache.org/jira/browse/CLOUDSTACK-7539 > > > Repository: cloudstack-git > > > Description > --- > > Root

Review Request 26263: CLOUDSTACK-7539: [S3] Parallel deployment makes reference count of a cache in nfs secondary staging store negative(-1)

2014-10-03 Thread Hiroki Ohashi
) - CLOUDSTACK-7539: [S3] Parallel deployment makes reference count of a cache in nfs secondary staging store negative(-1) Bugs: CLOUDSTACK-7539 https://issues.apache.org/jira/browse/CLOUDSTACK-7539 Repository: cloudstack-git Description (updated) --- Root causes of