Sure.
On 7/7/14, 2:01 PM, "Daan Hoogland" wrote:
>Alena, I had no time at all to look at cloudstack today, could you
>apply it please. My $dayjob duties are requiring a slightly different
>focus the coming week(s)
>
>thanks
>
>On Mon, Jul 7, 2014 at 6:42 PM, Alena Prokharchyk
> wrote:
>> Yes, th
Alena, I had no time at all to look at cloudstack today, could you
apply it please. My $dayjob duties are requiring a slightly different
focus the coming week(s)
thanks
On Mon, Jul 7, 2014 at 6:42 PM, Alena Prokharchyk
wrote:
> Yes, that¹s what I mean - by now, we should log them, but without lo
Yes, that¹s what I mean - by now, we should log them, but without logging
the trace. So your fix is correct.
Later, we should fix the installation process so the user is inserted only
once; and change the logic in ConfigurationServer - instead of logging the
exception, we should throw the RuntimeE
Alena, I really want to fix issues in this line, because I really want
us to use exceptions properly and never ignore them. So I would like
handle them or log at least. Thanks for your patients.
I am not sure of what you mean. Is this close:
diff --git a/server/src/com/cloud/server/ConfigurationS
Daan, there are similar problem in saveaccount/saveuser methods in thr same
class - introduced by this commit as well. I can fix it myself on Monday (Its
holiday days today and tomorrow at Citrix, usa); or you can revert them as well
along with the fix you do for network groups.
Let me know, an
On Thu, Jul 3, 2014 at 12:27 AM, Alena Prokharchyk
wrote:
> In any case, fixes done to ConfigurationManagerImpl are not correct, and
> logging should be fixed by reverting/reapplying the commit by following
> the rules defined in a) or b).
changing to
} catch (Exception ex)
Also SQLException is a checked exception meaning that the CS code knows
how to handle it:
} catch (SQLException ex) {
// if network_groups table exists, create the
default security group there
+s_logger.debug("Caught SQLException: no
network_gro
I have no idea, the scripts in the scripts/installer dir where written
by Manuel Amador before moving to apache.
On Wed, Jul 2, 2014 at 10:54 PM, Alena Prokharchyk
wrote:
> Its ok to log as long as the original problem - with the install script on
> RPM setup - is fixed along. I would prefer it t
Its ok to log as long as the original problem - with the install script on
RPM setup - is fixed along. I would prefer it to be fixed in a single
commit, otherwise the QA will continue seeing this bug and bringing it
over and over again. The fix for logging shouldn¹t go to the 4.5 release
w/o the or
On Wed, Jul 2, 2014 at 10:29 PM, Alena Prokharchyk
wrote:
> c031eb7d38200d680da85ef57367b21df3483c41
So please amend and not revert? I suppose you are talking about
@@ -508,8 +512,9 @@ public class ConfigurationServerImpl extends
ManagerBase implements Configuratio
Prepa
Daan,
We have to temporarily revert the commit (looks like it exists in master branch
only)
commit c031eb7d38200d680da85ef57367b21df3483c41
Author: Ding Yuan 2014-04-14 14:02:03
Committer: Daan Hoogland 2014-04-14 23:07:15
CLOUDSTACK-6242: exception handling improvements
Or at least reve
11 matches
Mail list logo
