Re: [discuss] 80 char max length leads to illegiable source

2013-07-17 Thread Isaac Chiang
Hi all: Can we also have the coding convention for javascript on WIKI page? I found there are many "tab indents" and less styled code blocks in the UI code. Thanks, On Tue, Jul 16, 2013 at 11:49 PM, Joe Brockmeier wrote: > On Tue, Jul 16, 2013, at 10:37 AM, Alex Huang wrote: > > I u

Re: [discuss] 80 char max length leads to illegiable source

2013-07-16 Thread Joe Brockmeier
On Tue, Jul 16, 2013, at 10:37 AM, Alex Huang wrote: > I updated the wiki because several people asked me to post my eclipse > preference file which includes 180 column widths. There's also a follow > up mail thread after I checked it in. The column width was not > questioned. I can send out a s

RE: [discuss] 80 char max length leads to illegiable source

2013-07-16 Thread Donal Lafferty
> -Original Message- > From: Joe Brockmeier [mailto:j...@zonker.net] > Sent: 16 July 2013 3:02 PM > To: dev@cloudstack.apache.org > Subject: Re: [discuss] 80 char max length leads to illegiable source > > On Tue, Jul 16, 2013, at 08:02 AM, Donal Lafferty wrote: >

RE: [discuss] 80 char max length leads to illegiable source

2013-07-16 Thread Alex Huang
s are already using it. --Alex > -Original Message- > From: Joe Brockmeier [mailto:j...@zonker.net] > Sent: Tuesday, July 16, 2013 7:26 AM > To: dev@cloudstack.apache.org > Subject: Re: [discuss] 80 char max length leads to illegiable source > > On Tue, Jul 16, 201

Re: [discuss] 80 char max length leads to illegiable source

2013-07-16 Thread Joe Brockmeier
On Tue, Jul 16, 2013, at 08:53 AM, Alex Huang wrote: > Donal, > > Our coding convention says 180. It was discussed about a week or two > back. So, I am surprised that it's already been changed. I noticed the comment when I was doing the weekly news - but it was buried in an email with the subjec

RE: [discuss] 80 char max length leads to illegiable source

2013-07-16 Thread Donal Lafferty
My mistake. I'll have to update my style rules. DL > -Original Message- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: 16 July 2013 2:54 PM > To: dev@cloudstack.apache.org > Subject: RE: [discuss] 80 char max length leads to illegiable source > &

Re: [discuss] 80 char max length leads to illegiable source

2013-07-16 Thread Joe Brockmeier
On Tue, Jul 16, 2013, at 08:02 AM, Donal Lafferty wrote: > Can we loosen/ignore this rule when readability becomes an issue? Alex raised this issue last week: http://markmail.org/message/z2hzz7efujgmhfnh I didn't see many responses to that particular part of his email, though. Personally, I th

RE: [discuss] 80 char max length leads to illegiable source

2013-07-16 Thread Alex Huang
2 AM > To: dev@cloudstack.apache.org > Subject: [discuss] 80 char max length leads to illegiable source > > This issue appeared when I used StyleCheck and Eclipse to find and fix my > coding convention violations automatically. Details at > http://dlafferty.blogspot.co.uk/201

[discuss] 80 char max length leads to illegiable source

2013-07-16 Thread Donal Lafferty
This issue appeared when I used StyleCheck and Eclipse to find and fix my coding convention violations automatically. Details at http://dlafferty.blogspot.co.uk/2013/07/apache-cloudstack-java-coding.html We inherit the 80 char line limit inherited from the Java Programming Style, and it makes