Re: [PROPOSAL] Freeze everything until we get CI

2016-02-01 Thread Bharat Kumar
Sure Remi, Once I am done consolidating the scripts i will put them in a separate repo on github. Thanks, Bharat. > On 30-Jan-2016, at 5:14 PM, Remi Bergsma wrote: > > Please put it in a separate repo. There’s way too much stuff in the > cloudstack repo already, IMHO and we should be splitt

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-30 Thread Remi Bergsma
Please put it in a separate repo. There’s way too much stuff in the cloudstack repo already, IMHO and we should be splitting out, not adding more :-) Regards, Remi On 29/01/16 08:22, "Erik Weber" wrote: >I'd love to see this in the cloudstack repository. >Others might have an easier time g

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Erik Weber
I'd love to see this in the cloudstack repository. Others might have an easier time getting access to hardware, and could use it to help test releases/PR Erik Den fredag 29. januar 2016 skrev Bharat Kumar følgende: > yes, we would be sharing it with the community and get this running in the >

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Bharat Kumar
yes, we would be sharing it with the community and get this running in the ACS infra. Currently it can create a cloudstack test bed, runs tests and email the results. Here are some details on how this works and what is needed to set this up. * we use jenkins, cobbler, puppet and marvin to cr

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Erik Weber
Why not share it as is, then the community could help improving this, rather than this being a single company effort? -- Erik On Thu, Jan 28, 2016 at 1:49 PM, Bharat Kumar wrote: > Hi All, > > I agree that we need to have a CI to deal with the large volume of PRs. > The current travis CI is no

RE: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Paul Angus
//www.shapeblue.com> -Original Message- From: Bharat Kumar [mailto:bharat.ku...@citrix.com] Sent: 28 January 2016 21:50 To: Cc: David Nalley Subject: Re: [PROPOSAL] Freeze everything until we get CI Hi All, I agree that we need to have a CI to deal with the large volume of PRs.

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Bharat Kumar
Hi All, I agree that we need to have a CI to deal with the large volume of PRs. The current travis CI is not good enough as it runs only simulator tests. We identified this issue and came up with a effective CI for automating test runs for a each PR. This is already functional, with few github i

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Rohit Yadav
All, I’m sorry to get to have the PRs merged without adhering to the strict testing requirements. While I think PRs were alright and it did not break anything, the way it was merged made people uncomfortable that there is some sort of haste in doing this fast which there is none. I’ll not repe

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Sebastien Goasguen
Hi Folks, My proposal to freeze until we get CI was indeed due to seeing Rohit’s commit but was by no means a personal attack or judgment. We have lots of PR pending (as mentioned before by Remi) and we need people to help review and test. So thanks to Rohit. My only concerns were two fold: 1

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Rohit Yadav
So, since some have directly (over IM etc) or indirectly have thrown allegations on me since I merged most of the PRs. Here is a list of those 12 PRs and answers on why they were merged on case-by-case basis. Please keep any further replies technical and to the specific PR, please point out and

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Daan Hoogland
On Wed, Jan 27, 2016 at 9:18 PM, Sebastien Goasguen wrote: > Now Travis is not running, Jenkins fails all the time and nobody cares… > ​Sebastien, Jenkins succeeds more then 50% of the time and I do care. Please report problems with jenkins.​ -- Daan

RE: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Paul Angus
blue.com<mailto:paul.an...@shapeblue.com>| w: www.shapeblue.com<http://www.shapeblue.com> -Original Message- From: Remi Bergsma [mailto:rberg...@schubergphilis.com] Sent: 28 January 2016 17:57 To: dev@cloudstack.apache.org Subject: Re: [PROPOSAL] Freeze everyth

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Remi Bergsma
apache.org>" mailto:dev@cloudstack.apache.org>> Date: Thursday 28 January 2016 09:50 To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" mailto:dev@cloudstack.apache.org>> Subject: Re: [PROPOSAL] Freeze everything until we get CI [ShapeBl

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Remi Bergsma
: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" mailto:dev@cloudstack.apache.org>> Date: Thursday 28 January 2016 09:29 To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" mailto:dev@cloudstack.apache.org>> Subject: RE: [PROPOSAL] Freeze

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Rohit Yadav
[ShapeBlue] Rohit Yadav Software Architect , ShapeBlue d: | s: +44 203 603 0540 | m: +91 8826230892 e: rohit.ya...@shapeblue.com | t: | w: www.shapeblue.com

RE: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Paul Angus
r. -Original Message- From: Bharat Kumar [mailto:bharat.ku...@citrix.com] Sent: 28 January 2016 14:45 To: Subject: Re: [PROPOSAL] Freeze everything until we get CI Hi, I agree with Remi on the hurdles he mentioned. It is difficult to integrate 3rd party CI, If someone wants to impl

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Rohit Yadav
[ShapeBlue] Rohit Yadav Software Architect , ShapeBlue d: | s: +44 203 603 0540 | m: +91 8826230892 e: rohit.ya...@shapeblue.com | t: | w: www.shapeblue.com

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-27 Thread Bharat Kumar
Hi, I agree with Remi on the hurdles he mentioned. It is difficult to integrate 3rd party CI, If someone wants to implement their own CI, the link below gives one way to do it. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integr

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-27 Thread Wido den Hollander
On 01/27/2016 10:02 PM, Remi Bergsma wrote: > Hi all, > > We should keep the simple approach that was used until now: one LGTM based on > code review and one LGTM based on integration tests (that’s not the same as > 2xLGTM). > > If we care about master stability, every change has to be tested

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-27 Thread Remi Bergsma
This won’t fly, you will get no hook approved. Instead, simply poll the Github API every x minutes for new PRs and then start your test. Regards, Remi On 27/01/16 21:59, "Rafael Weingärtner" wrote: >Because that would require manual work (reporting back the results), maybe >if we figure ou

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-27 Thread Remi Bergsma
Hi all, We should keep the simple approach that was used until now: one LGTM based on code review and one LGTM based on integration tests (that’s not the same as 2xLGTM). If we care about master stability, every change has to be tested for regression. Period. Things may look OK, but still brea

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-27 Thread Rafael Weingärtner
Because that would require manual work (reporting back the results), maybe if we figure out some way to dispatch the request to run tests with a PR against an environment. If we had a repository in which developers could register their environment to receive requests to run tests on a given PR, an

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-27 Thread Sebastien Goasguen
> On Jan 27, 2016, at 9:42 PM, Rafael Weingärtner > wrote: > > +1 Sebastian, > I would ask the same as Wilder, why the rush to merge those PRs without > actual test and reviews (some LGTMs there I would not count)? They did not > seem to be that important. > > I believe that the idea to run PR

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-27 Thread Rafael Weingärtner
+1 Sebastian, I would ask the same as Wilder, why the rush to merge those PRs without actual test and reviews (some LGTMs there I would not count)? They did not seem to be that important. I believe that the idea to run PRs totally distributed in everyone’s environments would not be feasible today.

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-27 Thread Sebastien Goasguen
> On Jan 27, 2016, at 9:25 PM, Wido den Hollander wrote: > > > > On 01/27/2016 09:18 PM, Sebastien Goasguen wrote: >> Folks, >> >> How about we freeze our repo entirely until we get proper CI in place. >> >> Seems to me all the hard work from Remi and co could be lost if we start >> committ

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-27 Thread Wilder Rodrigues
+1 , Sebastien! From the last 12 PRs that were merged, only 2 had integration tests executed against. I don’t understand why the rush to merge things that were not properly tested. It already looks like a broken master and 4 votes to get 1 release through every 9 months. I should not make such

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-27 Thread Wido den Hollander
On 01/27/2016 09:18 PM, Sebastien Goasguen wrote: > Folks, > > How about we freeze our repo entirely until we get proper CI in place. > > Seems to me all the hard work from Remi and co could be lost if we start > committing again. > > Now Travis is not running, Jenkins fails all the time and

[PROPOSAL] Freeze everything until we get CI

2016-01-27 Thread Sebastien Goasguen
Folks, How about we freeze our repo entirely until we get proper CI in place. Seems to me all the hard work from Remi and co could be lost if we start committing again. Now Travis is not running, Jenkins fails all the time and nobody cares… So how about we figure out CI now ? and not do anythi