Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-12-14 Thread via GitHub
CodeBleu commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1885480207 ## cloudstack/service_offering_schema.go: ## @@ -0,0 +1,248 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-12-09 Thread via GitHub
CodeBleu commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2528623201 > The error is being thrown from cloudstacks API. Try setting this global var to 0. > > ``` > Custom diskoffering size min (custom.diskoffering.size.min)

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-12-09 Thread via GitHub
poddm commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2528307069 The error is being thrown from cloudstacks API. Try setting this global var to 0. ``` Custom diskoffering size min (custom.diskoffering.size.min) Minimum s

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-12-05 Thread via GitHub
CodeBleu commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2520831858 > > @poddm Was wondering if you could help me with this ☝️ ? I need the `storage_type` to be what my terraform is set to, but it's not. [#138 (comment)](https://gith

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-12-04 Thread via GitHub
poddm commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2519048554 > @poddm Was wondering if you could help me with this ☝️ ? I need the `storage_type` to be what my terraform is set to, but it's not. [#138 (comment)](https://github.co

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-12-03 Thread via GitHub
CodeBleu commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2515516610 @poddm Was wondering if you could help me with this? I need the storage_type to be what my terraform is set to, but it's not. https://github.com/apache/cloudsta

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-30 Thread via GitHub
CodeBleu commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2448287725 @poddm > I fixed the duplicate storage_offering field. > Thanks, I will test this later. My main issue was the `storage_type` would not change to what I s

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-30 Thread via GitHub
CodeBleu commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2447330444 @poddm Not sure if you saw that I'm still having issues with this or not. Wondering what I need to do? https://github.com/apache/cloudstack-terraform-provider/pu

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-29 Thread via GitHub
poddm commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1821403742 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-29 Thread via GitHub
poddm commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1821372710 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-29 Thread via GitHub
poddm commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1821365313 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-28 Thread via GitHub
CodeBleu commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2442665334 > > @poddm Thank you so much for looking into this. > > Once this offering stuff is complete, I still need a way to implement this with the `cloudstack_instance` r

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-28 Thread via GitHub
poddm commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2442527839 > @poddm Thank you so much for looking into this. > > Once this offering stuff is complete, I still need a way to implement this with the `cloudstack_instance` re

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818021536 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2439927211 @poddm I haven' tested but PR looks good. Left some minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818022462 ## cloudstack/service_offering_models.go: ## @@ -0,0 +1,70 @@ +package cloudstack + +import "github.com/hashicorp/terraform-plugin-framework/type

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818020162 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818019905 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818020077 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818019962 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818019873 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-26 Thread via GitHub
CodeBleu commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2439588601 @poddm Thank you so much for looking into this. Once this offering stuff is complete, I still need a way to implement this with the `cloudstack_instance` resou

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-25 Thread via GitHub
CodeBleu commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2438448539 > @CodeBleu , I fixed the domain ids issue. Try now. > > Also, regarding the documentation. I was looking at using the generator but it might be better to scop

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-24 Thread via GitHub
poddm commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2436599898 @CodeBleu , I fixed the domain ids issue. Try now. Also, regarding the documentation. I was looking at using the generator but it might be better to scope all t