Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-10-22 Thread via GitHub
CodeBleu commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2429584913 This PR has been replaced with this [PR](https://github.com/apache/cloudstack-terraform-provider/pull/138) -- This is an automated message from the Apache Git Servic

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-10-21 Thread via GitHub
CodeBleu commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2427656309 @poddm I see you're working on this. Thanks!! I've been trying to test things before your recent changes, and have pulled down your recent changes too, but I believe

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-10-21 Thread via GitHub
poddm closed pull request #77: service and disk offerings URL: https://github.com/apache/cloudstack-terraform-provider/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-10-21 Thread via GitHub
poddm closed pull request #77: service and disk offerings URL: https://github.com/apache/cloudstack-terraform-provider/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-10-20 Thread via GitHub
rohityadavcloud commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2424695034 @poddm can you review/rebase the PR & look at failing tests. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-10-20 Thread via GitHub
rohityadavcloud commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2424692987 Hi @CodeBleu on the next release, we can try to start some release work in end Nov & Dec, I don't think some of us will have bandwidth until CCC (Nov 22-23). I'

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-10-17 Thread via GitHub
CodeBleu commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2419993022 @poddm Unless I'm missing something, shouldn't there be updates to the [cloudstack_instance](https://registry.terraform.io/providers/cloudstack/cloudstack/latest/docs/r

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-10-17 Thread via GitHub
CodeBleu commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2419722094 @poddm @rohityadavcloud Since we are now in the 4th quarter, I was hoping we can start wrapping things like this up and get a new release out soon. This one PR in pa

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-10-11 Thread via GitHub
CodeBleu commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2407545927 > I missed these previous messages. Let me look at refactoring this into the new framework SDK. @poddm Any update in this? I really would like to have the dynami

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-09-13 Thread via GitHub
poddm commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2349195371 I missed these previous messages. Let me look at refactoring this into the new framework SDK. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-09-13 Thread via GitHub
CodeBleu commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2349175511 > > @poddm The build is failing. Please check. Also, I am not sure about removing existing resource types. This can cause issues for users during an upgrade. I haven't

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-23 Thread via GitHub
CodeBleu commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2307047908 > @poddm The build is failing. Please check. Also, I am not sure about removing existing resource types. This can cause issues for users during an upgrade. I haven't c

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-23 Thread via GitHub
vishesh92 commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2306812361 @poddm The build is failing. Please check. Also, I am not sure about removing existing resource types. This can cause issues for users during an upgrade. I haven't

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-22 Thread via GitHub
poddm commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2304969221 @rohityadavcloud, I'm interested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-21 Thread via GitHub
rohityadavcloud commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2303854174 @poddm @fabiomatavelli I was on vacation so couldn't reply earlier. Longer term, since you're both active contributors and if you want to main and drive r

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-14 Thread via GitHub
poddm commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2289153210 I can remove `cloudstack_disk_offering` to not conflict with the other changes. I'd like to keep the separate types to align the GUI presentation and make it easie

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-14 Thread via GitHub
CodeBleu commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2289085537 @fabiomatavelli @rohityadavcloud @poddm Can we come to an agreement on service_offerings between this PR and what @fabiomatavelli had worked on here #113 and move fo

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-04-25 Thread via GitHub
rohityadavcloud commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2078605739 @poddm can you address conflicts on your PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-04-25 Thread via GitHub
poddm commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2078546501 Update - I'd still like to get these merged once the cloudstack SDK is updated. - https://github.com/apache/cloudstack-terraform-provider/pull/71 - https://github.co

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-02-12 Thread via GitHub
adidiborg commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-1940493371 > Hi @adidiborg welcome to the opensource project, I hear you and I hope the community can work towards a release soon. I hope the next TF release will be sometime in

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-02-12 Thread via GitHub
rohityadavcloud commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-1940435831 Hi @adidiborg welcome to the opensource project, I hear you and I hope the community can work towards a release soon. I hope the next TF release will be sometim

Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-02-12 Thread via GitHub
adidiborg commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-1939069300 Hi @rohityadavcloud, any tentative timelines when v0.5.0 would release? Already merged features could be of a lot of use 😄 -- This is an automated message from the