shwstppr closed pull request #77: restore methods with 4.19 optional API params
URL: https://github.com/apache/cloudstack-go/pull/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
weizhouapache commented on PR #77:
URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1976309995
> Another alternative approach I can think of is generating multiple modules
as per the ACS version. Every release of cloudstack-go will have multiple
modules for different AC
vishesh92 commented on PR #77:
URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1976261911
If someone upgrades their cloudstack-go SDK and builds their project, the
build will fail only if some method which is now changed is being used. Any
good IDE should be able to list d
weizhouapache commented on PR #77:
URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1956977692
> Next time we generate the code, we will have to do these changes again. If
we plan to support this for next release only, then it's fine. Otherwise it
would be better to make it
vishesh92 commented on PR #77:
URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1956808293
Next time we generate the code, we will have to do these changes again. If
we plan to support this for next release only, then it's fine. Otherwise it
would be better to make it part
weizhouapache commented on PR #77:
URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1956139850
looks ok to me
@hrak @rohityadavcloud
what's your opinion ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
shwstppr opened a new pull request, #77:
URL: https://github.com/apache/cloudstack-go/pull/77
ACS 4.19 makes some parameters optional for some of the APIs. If they are
removed from the constructors it may break compatibility with older ACS
releases. Since golang doesn't support method overl
