Re: [PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-09 Thread via GitHub
mlsorensen commented on code in PR #86: URL: https://github.com/apache/cloudstack-go/pull/86#discussion_r1595570927 ## generate/generate.go: ## @@ -58,6 +58,20 @@ var detailsRequireZeroIndex = map[string]bool{ "updateAccount":true, } +// requiresPost is a prefille

Re: [PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-09 Thread via GitHub
mlsorensen merged PR #86: URL: https://github.com/apache/cloudstack-go/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstac

Re: [PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-09 Thread via GitHub
mlsorensen commented on code in PR #86: URL: https://github.com/apache/cloudstack-go/pull/86#discussion_r1595570927 ## generate/generate.go: ## @@ -58,6 +58,20 @@ var detailsRequireZeroIndex = map[string]bool{ "updateAccount":true, } +// requiresPost is a prefille

Re: [PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-09 Thread via GitHub
vishesh92 commented on PR #86: URL: https://github.com/apache/cloudstack-go/pull/86#issuecomment-2102551076 > code looks good to me. Need to verify if the new methods work as expected. Verified createUser & updateUser methods. -- This is an automated message from the Apache Git Serv

Re: [PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-09 Thread via GitHub
vishesh92 commented on code in PR #86: URL: https://github.com/apache/cloudstack-go/pull/86#discussion_r1595362237 ## generate/generate.go: ## @@ -58,6 +58,20 @@ var detailsRequireZeroIndex = map[string]bool{ "updateAccount":true, } +// requiresPost is a prefilled

Re: [PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-07 Thread via GitHub
mlsorensen commented on PR #86: URL: https://github.com/apache/cloudstack-go/pull/86#issuecomment-2098669151 Fixes #85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-07 Thread via GitHub
mlsorensen opened a new pull request, #86: URL: https://github.com/apache/cloudstack-go/pull/86 Add a set to contain the API names that should use POST. Not all defined API names here are actually generated by this client yet (namely the 2FA and registerUserData APIs), but would want to be