Re: [PR] Restore methods with optional params for 4.19 compatability [cloudstack-go]

2024-03-14 Thread via GitHub
shwstppr merged PR #80: URL: https://github.com/apache/cloudstack-go/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.

Re: [PR] Restore methods with optional params for 4.19 compatability [cloudstack-go]

2024-03-14 Thread via GitHub
weizhouapache commented on PR #80: URL: https://github.com/apache/cloudstack-go/pull/80#issuecomment-1997179814 thanks @vishesh92 it looks terraform will not work https://github.com/apache/cloudstack-terraform-provider/blob/d524e07e497b44caf3252fe9ffeefbc6bd138570/cloudstack/r

Re: [PR] Restore methods with optional params for 4.19 compatability [cloudstack-go]

2024-03-13 Thread via GitHub
weizhouapache commented on PR #80: URL: https://github.com/apache/cloudstack-go/pull/80#issuecomment-1994006010 I checked the diff betwen this PR and latest v2.15.0 1. guest OS (**_no need to fix I think_**) ``` type GuestOSServiceIface interface { AddGuestOs(p *A

Re: [PR] Restore methods with optional params for 4.19 compatability [cloudstack-go]

2024-03-13 Thread via GitHub
weizhouapache commented on PR #80: URL: https://github.com/apache/cloudstack-go/pull/80#issuecomment-1993901948 @vishesh92 clustertype is always an optional parameter, right? In the official ACS/cloudstack-go releases I mean. -- This is an automated message from the Apache

[PR] Restore methods with optional params for 4.19 compatability [cloudstack-go]

2024-03-12 Thread via GitHub
vishesh92 opened a new pull request, #80: URL: https://github.com/apache/cloudstack-go/pull/80 Add optional params from https://github.com/apache/cloudstack-go/pull/77 to the `requiredParams.go`. -- This is an automated message from the Apache Git Service. To respond to the message, pleas