Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-04-23 Thread via GitHub
sureshanaparti commented on code in PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2056117130 ## cloudstack/QuotaService.go: ## @@ -192,7 +192,7 @@ func (s *QuotaService) NewQuotaBalanceParams(account string, domainid string) *Q // Create a quota

Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-04-23 Thread via GitHub
sureshanaparti commented on code in PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2056114303 ## cloudstack/QuotaService.go: ## @@ -801,7 +801,7 @@ func (s *QuotaService) NewQuotaSummaryParams() *QuotaSummaryParams { // Lists balance and quota usa

Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-04-23 Thread via GitHub
sureshanaparti commented on code in PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2056115362 ## cloudstack/QuotaService.go: ## @@ -1449,7 +1449,7 @@ func (s *QuotaService) NewQuotaTariffListParams() *QuotaTariffListParams { // Lists all quota tar

Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-04-23 Thread via GitHub
sureshanaparti commented on code in PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2056112815 ## cloudstack/QuotaService.go: ## @@ -598,7 +598,7 @@ func (s *QuotaService) NewQuotaStatementParams(account string, domainid string, // Create a quota s

Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-04-23 Thread via GitHub
sureshanaparti commented on code in PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2056111744 ## cloudstack/QuotaService.go: ## @@ -408,7 +408,7 @@ func (s *QuotaService) NewQuotaIsEnabledParams() *QuotaIsEnabledParams { // Return true if the plug

Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-04-23 Thread via GitHub
sureshanaparti commented on code in PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2056084151 ## cloudstack/ManagementService.go: ## @@ -804,7 +804,7 @@ func (s *ManagementService) NewReadyForShutdownParams() *ReadyForShutdownParams // Returns the

Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-04-23 Thread via GitHub
sureshanaparti commented on code in PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2056077237 ## cloudstack/CloudianService.go: ## @@ -51,7 +51,7 @@ func (s *CloudianService) NewCloudianIsEnabledParams() *CloudianIsEnabledParams // Checks if the C

Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-04-23 Thread via GitHub
sureshanaparti commented on code in PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2056053999 ## cloudstack/AccountService.go: ## @@ -1104,7 +1104,7 @@ func (s *AccountService) NewIsAccountAllowedToCreateOfferingsWithTagsParams() *I // Return true

Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-04-16 Thread via GitHub
kevin-lii commented on code in PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2047779261 ## generate/generate.go: ## @@ -560,7 +560,7 @@ func (as *allServices) GeneralCode() ([]byte, error) { pn("// Execute the request against a CS API. Will r

Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-04-16 Thread via GitHub
rohityadavcloud commented on code in PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2046235561 ## generate/generate.go: ## @@ -560,7 +560,7 @@ func (as *allServices) GeneralCode() ([]byte, error) { pn("// Execute the request against a CS API.

[PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-04-15 Thread via GitHub
kevin-lii opened a new pull request, #107: URL: https://github.com/apache/cloudstack-go/pull/107 Currently State Changing Request utilize GET request but this is a potential security vulnerability since attackers may be able to intercept and extract the query parameters of GET requests. Uti