DaanHoogland merged PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
DaanHoogland commented on PR #140:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1795151344
liberally stealing from my chat with @Pearl1594;
before :
```
(nsx) 🐱 > deploy virtualmachine name=test-cmk-post-ud
serviceofferingid=cbbe6556-3bdb-4bc7-92f6-9
DaanHoogland commented on PR #140:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1794876078
after a short discuss off(this)line with @Pearl1594 , the performance is not
very relevant as with only 2kb of url length userdata is going to be too long
easily. If we
rohityadavcloud commented on PR #140:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1791029733
@DaanHoogland @Pearl1594 is there a way you could test against large
userdata input string to see how it behaves wrt post vs get request?
--
This is an automated m
DaanHoogland commented on code in PR #140:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/140#discussion_r1380289018
##
cmd/network.go:
##
@@ -243,9 +252,18 @@ func NewAPIRequest(r *Request, api string, args []string,
isAsync bool) (map[str
params.A
rohityadavcloud commented on PR #140:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1782352212
@mlsorensen can you share a test userdata string/content for us to
test/reproduce it? Could you also check mgmt server logs (share the same)? It
could be a limitatio
mlsorensen commented on PR #140:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1779610165
FYI - I tested this out and am getting auth errors via keys if I try to call
`deploy virtualmachine` or `update virtualmachine` with large userdata.
```
% ./cmk
mlsorensen commented on PR #140:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1779608937
FYI - I tested this out and am getting auth errors via keys if I try to call
`deploy virtualmachine` or `update virtualmachine` with large userdata.
```
% ./cmk
mlsorensen commented on PR #140:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1761419545
Can we get a config item for the user to choose POST or not e.g. `set method
[post|get]`? This may be desirable for other calls that may contain large
payload or secret
