Re: [PR] 4.19 support changes [cloudstack-go]

2024-02-08 Thread via GitHub
rohityadavcloud commented on PR #76: URL: https://github.com/apache/cloudstack-go/pull/76#issuecomment-1935381113 LGTM - merged @shwstppr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] 4.19 support changes [cloudstack-go]

2024-02-08 Thread via GitHub
rohityadavcloud merged PR #76: URL: https://github.com/apache/cloudstack-go/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@clou

Re: [PR] 4.19 support changes [cloudstack-go]

2024-02-08 Thread via GitHub
shwstppr commented on PR #76: URL: https://github.com/apache/cloudstack-go/pull/76#issuecomment-1935378963 Tests are passing both locally and in GH action -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] 4.19 support changes [cloudstack-go]

2024-02-08 Thread via GitHub
rohityadavcloud commented on PR #76: URL: https://github.com/apache/cloudstack-go/pull/76#issuecomment-1934036466 LGTM - didn't test it. Are there basic build/tests that cover basic checks? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] 4.19 support changes [cloudstack-go]

2024-02-08 Thread via GitHub
shwstppr commented on PR #76: URL: https://github.com/apache/cloudstack-go/pull/76#issuecomment-1933949015 @Pearl1594 @rohityadavcloud @vishesh92 If you approve, we can merge and create a new release -- This is an automated message from the Apache Git Service. To respond to the message, p

[PR] 4.19 support changes [cloudstack-go]

2024-02-07 Thread via GitHub
shwstppr opened a new pull request, #76: URL: https://github.com/apache/cloudstack-go/pull/76 For cutting 4.19 support release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment