Re: [MERGE] diso_io_stat branch into MASTER

2013-05-31 Thread Wei ZHOU
Hi Wido, I put all the database changes into setup/db/db/schema-410to420.sql. I have tested on devcloud and our testing enviroment, it is ok. -Wei 2013/5/31 Wido den Hollander > Hi Wei, > > > On 05/30/2013 05:47 PM, Wei ZHOU wrote: > >> Hi, >> >> I would like to merge disk_io_stat branch into

Re: [MERGE] diso_io_stat branch into MASTER

2013-05-31 Thread Prasanna Santhanam
On Fri, May 31, 2013 at 02:16:31PM +0200, Wido den Hollander wrote: > > Shouldn't there be a creation of the tables in create-schema.sql as > well? This is for newly created clusters. > Think Wei is right on this one - we froze create-schema.sql at 4.0 See: https://cwiki.apache.org/CLOUDSTACK/da

Re: [MERGE] diso_io_stat branch into MASTER

2013-05-31 Thread Wido den Hollander
Hi Wei, On 05/30/2013 05:47 PM, Wei ZHOU wrote: Hi, I would like to merge disk_io_stat branch into master. If nobody object, I will merge into master in 48 hours. I tried reviewing the whole patch and I mainly focused on the KVM side since that's what I know most about. Code wise it seems

Re: [MERGE] diso_io_stat branch into MASTER

2013-05-31 Thread Wei ZHOU
Hi Wido, I checked the source code. For RBD network devices, it should work well. In com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.createVbd(Connect, VirtualMachineTO, String, LibvirtVMDef) disk.defNetworkBasedDisk(physicalDisk.getPath().replace("rbd:", "") so disk.getPath() ret

Re: [MERGE] diso_io_stat branch into MASTER

2013-05-30 Thread Wei ZHOU
Wido, thanks for you review. QEMU/libvirt can get the bytes/iops for individual volume. path(or uuid) is a connection between volume (in cloudstack database) and volume (in QEMU). However, the first volume in QEMU is ROOTDISK, second volune is DATADISK. Maybe I can use this to get the value for R

Re: [MERGE] diso_io_stat branch into MASTER

2013-05-30 Thread Wei ZHOU
For now, This supports KVM only. There is an issue in Xen support as xenapi returns I/O rate (bytes per seconds) instead of total I/O. -Wei 2013/5/30 Wei ZHOU > Hi Wido, > > I have not tested on network block devices like Ceph, as I have no testing > environment. > I will change the source co

Re: [MERGE] diso_io_stat branch into MASTER

2013-05-30 Thread Wei ZHOU
Hi Wido, I have not tested on network block devices like Ceph, as I have no testing environment. I will change the source code and point out this does not support network block devices. It will support in the future. -Wei 2013/5/30 Wido den Hollander > On 05/30/2013 05:47 PM, Wei ZHOU wrote

Re: [MERGE] diso_io_stat branch into MASTER

2013-05-30 Thread Wido den Hollander
On 05/30/2013 05:47 PM, Wei ZHOU wrote: Hi, I would like to merge disk_io_stat branch into master. If nobody object, I will merge into master in 48 hours. First of all, awesome work! I created the ticket but never came around implementing it. I took a quick look at the code and saw this in

[MERGE] diso_io_stat branch into MASTER

2013-05-30 Thread Wei ZHOU
Hi, I would like to merge disk_io_stat branch into master. If nobody object, I will merge into master in 48 hours. The feature includes (1) Add disk I/O polling for instances to CloudStack. (2) Add it to the instance vm disk statistics table. (3) and add it to the usage database for optional b