Re: [MERGE] Support Granular SCSI disk controllers in CloudStack over VMware hypervisor

2015-02-13 Thread Daan Hoogland
v@cloudstack.apache.org >> Subject: Re: [MERGE] Support Granular SCSI disk controllers in CloudStack >> over VMware hypervisor >> >> Hi Sateesh, >> >> Can can send a Github PR for review (if you want to get a code review) and >> share code coverage wrt unit

RE: [MERGE] Support Granular SCSI disk controllers in CloudStack over VMware hypervisor

2015-02-12 Thread Sateesh Chodapuneedi
> -Original Message- > From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] > Sent: 14 January 2015 14:46 > To: dev@cloudstack.apache.org > Subject: Re: [MERGE] Support Granular SCSI disk controllers in CloudStack > over VMware hypervisor > > Hi Sateesh, > >

Re: [MERGE] Support Granular SCSI disk controllers in CloudStack over VMware hypervisor

2015-01-14 Thread Rohit Yadav
Hi Sateesh, Can can send a Github PR for review (if you want to get a code review) and share code coverage wrt unit (and integration) tests. I think if the code coverage is well above 80% I think everyone should be okay with the merge. Let me know if you need any help. On Wednesday 14 January 2

[MERGE] Support Granular SCSI disk controllers in CloudStack over VMware hypervisor

2015-01-13 Thread Sateesh Chodapuneedi
Hi, I would like merge the branch 'vmware-disk-controllers' into master branch. This branch contains implementation to support Granular SCSI disk controllers in CloudStack over VMware hypervisor. This is specific to VMware hypervisor only. The code changes are in area of vmware resource. All