Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648723
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import java.security.spec.InvalidKeySpecExc
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78649049
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import java.security.spec.InvalidKeySpecExc
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648669
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import java.security.spec.InvalidKeySpecExc
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648573
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import java.security.spec.InvalidKeySpecExc
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648332
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import java.security.spec.InvalidKeySpecExc
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647094
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647052
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648238
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import java.security.spec.InvalidKeySpecExc
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78648029
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -38,125 +38,139 @@
import java.security.spec.InvalidKeySpecExc
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647513
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -726,17 +729,17 @@ public void runDeleteSslCertInvalidId() throws
No
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647426
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -686,35 +689,35 @@ public void runDeleteSslCertBoundCert() throws
No
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647300
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -571,43 +573,44 @@ public void runUploadSslCertNotX509() throws
IOEx
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645945
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -348,90 +348,91 @@ public void runUploadSslCertNoRootCert() throws
I
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645447
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -297,48 +297,48 @@ public void runUploadSslCertNoRootCert() throws
I
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645238
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -297,48 +297,48 @@ public void runUploadSslCertNoRootCert() throws
I
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645782
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -348,90 +348,91 @@ public void runUploadSslCertNoRootCert() throws
I
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646098
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647140
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -571,43 +573,44 @@ public void runUploadSslCertNotX509() throws
IOEx
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78647190
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -571,43 +573,44 @@ public void runUploadSslCertNotX509() throws
IOEx
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646689
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646330
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646913
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646974
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646545
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78646056
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -440,129 +441,130 @@ public void runUploadSslCertBadkeyPair() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645990
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -348,90 +348,91 @@ public void runUploadSslCertNoRootCert() throws
I
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645872
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -348,90 +348,91 @@ public void runUploadSslCertNoRootCert() throws
I
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645670
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -348,90 +348,91 @@ public void runUploadSslCertNoRootCert() throws
I
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78645295
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -297,48 +297,48 @@ public void runUploadSslCertNoRootCert() throws
I
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644966
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -245,48 +245,48 @@ public void runUploadSslCertSelfSignedNoPassword()
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644844
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -245,48 +245,48 @@ public void runUploadSslCertSelfSignedNoPassword()
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644684
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -200,23 +200,23 @@ public void runUploadSslCertSelfSignedWithPassword
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644729
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -200,23 +200,23 @@ public void runUploadSslCertSelfSignedWithPassword
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644594
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -125,48 +125,48 @@ public void runUploadSslCertWithCAChain() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78644423
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -125,48 +125,48 @@ public void runUploadSslCertWithCAChain() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78643673
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78643413
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78642099
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78642059
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78641993
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78641717
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78640135
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78639151
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78638892
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78638846
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78638396
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -111,37 +116,37 @@ public CertServiceImpl() {
@DB
@O
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r78638045
--- Diff: pom.xml ---
@@ -70,7 +70,7 @@
4.12
1.3
-1.46
+1.54
--- End diff --
it appears that
[1
47 matches
Mail list logo
