Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-218847217
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-218838201
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 4h 19m 54s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-218838385
Can I get another code review so this can be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user hogniRunar commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-203448721
To reproduce it you just need to set up a basic baremetal zone, start an
instance and on the bootserver for baremetal you can look at
/var/www/html/metadata//met
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-203437320
Hi @hogniRunar,
The code change LGTM. I verified for references to the function, but did
not test it. Could you create a JIRA ticket for it please? Could you
GitHub user hogniRunar opened a pull request:
https://github.com/apache/cloudstack/pull/1456
writeIfNotHere requires an array of strings, not a string
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greenqloud/cloudstack
pr-4.7-
