[GitHub] cloudstack pull request: unittesting: test resolution is not guara...

2015-08-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/633#issuecomment-135033195 @DaanHoogland: @wilderrodrigues will make a PR to remove it --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: unittesting: test resolution is not guara...

2015-08-26 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/633#issuecomment-135032095 @miguelaferreira it is proven to be of no use. For what I am concerned we should remove it totally. We can not guarantee any kind of realtime result in/with thi

[GitHub] cloudstack pull request: unittesting: test resolution is not guara...

2015-08-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/633#issuecomment-135028483 @DaanHoogland @wilderrodrigues @bhaisaab What's the purpose of having this unit test? I've just seen this unit test fail in a travis build

[GitHub] cloudstack pull request: unittesting: test resolution is not guara...

2015-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/633 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: unittesting: test resolution is not guara...

2015-07-29 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/633#issuecomment-125896500 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: unittesting: test resolution is not guara...

2015-07-29 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/633#issuecomment-125896323 Thanks, @DaanHoogland! LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: unittesting: test resolution is not guara...

2015-07-29 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/633 unittesting: test resolution is not guaranteed to be exact a lot of validation pull requests are failing over this test. It should pass but it's failure is environmental in any observed cas