Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205654507
@bhaisaab here you go: https://issues.apache.org/jira/browse/CLOUDSTACK-9335
please update the PR and add the issue to the title
---
If your project is s
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205643191
@swill feel free to create a JIRA ticket for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205512194
Pulled this in manually and tested it.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205509785
I agree. @bhaisaab do you mind adding a Jira ticket for this just so we
have a record of it.
---
If your project is set up for it, you can reply to this email and h
Github user eriweb commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205507905
Would be great with a jira ticket to track it though :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205501305
I agree. I just want to make sure others agree with us...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205500155
I believe we have to be reasonable when asking/requiring functional tests.
After looking at the code, I am ok with the changes and the tests executed.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205488087
I don't think there are any CI tests that will actually test this. Can we
assume the verifications that you guys have done is good enough? Also, I see
that Jenkins
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205452667
Works as expected, LGTM.
