On 09-Jul-2015, at 3:21 pm, Daan Hoogland
mailto:daan.hoogl...@gmail.com>> wrote:
I think I look good to myself as well ;}
On Thu, Jul 9, 2015 at 11:44 AM, karuturi
mailto:g...@git.apache.org>> wrote:
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/563
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/563#issuecomment-119893211
@karuturi fair point, will add a JIRA ticket tracking this. Will re-push
with the JIRA ID and merge.
IMO one should be able to cast reviews, the minimum two
I think I look good to myself as well ;}
On Thu, Jul 9, 2015 at 11:44 AM, karuturi wrote:
> Github user karuturi commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/563#issuecomment-119891522
>
> +1 changes looks good. but, a jira ticket is required. Also, I dont
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/563#issuecomment-119891522
+1 changes looks good. but, a jira ticket is required. Also, I dont think
you can self vote ;)
---
If your project is set up for it, you can reply to this email
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/563#issuecomment-119889147
UI is not really my thing, but given the logic applied and the code itself,
LGTM too.
Cheers,
Wilder
---
If your project is set up for it, you
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/563#issuecomment-119875445
+1 LGTM (self)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/563
ui: Allow UI plugins to be shown on navigation bar
Introduces a boolean option in UI plugins setting it to 'true' would display
the UI plugin on the left navigation bar.
Signed-off-
