Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bheuvel commented on the pull request:
https://github.com/apache/cloudstack/pull/1242#issuecomment-172607827
Well, short answer, LGTM and seen it compile on Windows (only) with this
adjustment.
Longs answer has more to do with the object/code generating the path
`
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1242#issuecomment-172318654
Pinging @bheuvel to have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1242#issuecomment-168016689
didn't test but I have no further remarks: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1242#issuecomment-168010431
Any LGTMs on this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1242#discussion_r47495397
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUtilitiesHelperTest.java
---
@@ -37,8 +38,8 @@ public void te
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1242#discussion_r47495825
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUtilitiesHelperTest.java
---
@@ -37,8 +38,8 @@ public void testSSHK
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1242#discussion_r47483781
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUtilitiesHelperTest.java
---
@@ -37,8 +38,8 @@ public void
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1242
test: Fix Libvirt test so that it works on Windows
This test failed on Windows, using the File.separator it should run fine on
Windows.
You can merge this pull request into a Git repository by ru
