Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-221200314
LGTM based on code review and template build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-221185506
sure tag:easypr LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-221165014
Ping @wido @swill @DaanHoogland @abhinandanprateek can we get some
review/lgtm thanks. This fixes build environment issues, updates readme and
updates to use the las
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-217506509
Here is a build log to prove that build succeeds using a Ubuntu 16.04 slave
box with VirtualBox 5.0:
[systemvmtemplate-build-consoleText.txt](https://github.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1531#discussion_r62361025
--- Diff: tools/appliance/definitions/systemvmtemplate/definition.rb ---
@@ -27,15 +27,15 @@
architectures = {
:i386 => {
:os_typ
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1531#discussion_r62360986
--- Diff:
tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh ---
@@ -19,7 +19,7 @@
set -e
set -x
-CLOUDSTACK_R
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1531#discussion_r62360949
--- Diff: tools/appliance/build.sh ---
@@ -529,8 +534,6 @@ function vmware_export() {
stage_vmx ${appliance_build_name}-vmware
${appliance_build_n
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-217504212
@swill you can use this PR on a branch and build systemvm templates. I've
updated the README on how you can setup an environment to build yourself
systemvmtemplates a
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-217502707
how do I test this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-217413238
@swill this PR is ready for CI test run and merge, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1531
systemvmtemplate: fix build and upgrade to debian 7.10 iso
- Bumps base debian iso to version 7.10
- Upgrade ruby version to 2.3.0 (latest/stable)
- Fix Gemfile
- Update README
11 matches
Mail list logo