[GitHub] cloudstack pull request: systemvm - Python code cleanup

2016-06-01 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1575 This PR is not required in order to stabilize master. Correct? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: systemvm - Python code cleanup

2016-06-01 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1575 @romain-dartigues: Work is still underway indeed. I've tested the PR the last few days and it seems to be working. The problems we saw have been fixed and this code is currently runn

[GitHub] cloudstack pull request: systemvm - Python code cleanup

2016-06-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1575 @romain-dartigues in such cases you can fetch the branch of the submitter in your own workspace and build on top of it, push to your own fork on github and open a PR from that. When

[GitHub] cloudstack pull request: systemvm - Python code cleanup

2016-06-01 Thread romain-dartigues
Github user romain-dartigues commented on the pull request: https://github.com/apache/cloudstack/pull/1575 Thank you @wido for pointing it. Some problems are still present in #1547; should I wait it to be merged to redo the patch on top of it or do you have other suggestions? ---

[GitHub] cloudstack pull request: systemvm - Python code cleanup

2016-06-01 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1575 I think this PR is going to cause a conflict with #1547 That PR fixes a series of issues in the VR which are currently broken, mainly when using multiple ranges inside a POD VLAN wi

[GitHub] cloudstack pull request: systemvm - Python code cleanup

2016-05-31 Thread romain-dartigues
Github user romain-dartigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1575#discussion_r65191566 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/set_redundant.py --- @@ -1,47 +0,0 @@ -#!/usr/bin/python --- End diff --

[GitHub] cloudstack pull request: systemvm - Python code cleanup

2016-05-31 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1575#discussion_r65183997 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/set_redundant.py --- @@ -1,47 +0,0 @@ -#!/usr/bin/python --- End diff -- This

[GitHub] cloudstack pull request: systemvm - Python code cleanup

2016-05-31 Thread romain-dartigues
GitHub user romain-dartigues opened a pull request: https://github.com/apache/cloudstack/pull/1575 systemvm - Python code cleanup While debugging an issue on the System VM (to be reported later once we will have validated it behaviour); I took the opportunity to make some minor cod