[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/776 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138822497 I went through the file history and it has been like this since when it was pushed (back in 2012). The change makes sense and the explanations given about ha

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138525668 @wido @vincentbernat agree --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138476262 @vincentbernat Agreed, if we want a persistent file we should fix it in the packaging and not in the Python code. Code should never create files in a dynamic wa

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user vincentbernat commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138473948 @resmo the only problem with shipping a `/etc/sysctl.d/cloudstack.conf` is that this is more a packaging issue. It has to be handled for all distributions. And

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138465486 I prefer a persistent config (you know where to search for it) and not a dynamic one with hard coded values. If these would be dynamic, then it is clear to use the .py

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138465073 We have to LGTMs. Are we merging this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138336997 If we do not need to persist a file, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138310084 While looks good, I'll wait for comments from @remibergsma @miguelaferreira Ian and others on it was done this way? --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138244755 LGTM. We do not need a persistent file since this PY file will be called during runtime. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-137877024 +1 for /etc/sysctl.d/cloudStack.conf --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user vincentbernat commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-137765042 @resmo Yes, it could be in `/etc/sysctl.d` instead (and no sysctl call would be needed). I don't have a strong opinion on this (except in this case, the code s

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-137753484 Use a cloud(stack).conf file under /etc/sysctl.d/ seems better and follow the distro philosophy. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-137751754 Salut Vincent I agree, but AFAIK there is a `/etc/sysctl.d` directory intended for persistent sysctl configs. What about adding a `cloud.conf` to `/etc/sysctl.

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

GitHub user vincentbernat opened a pull request: https://github.com/apache/cloudstack/pull/776 sysctl: don't modify /etc/sysctl.conf To configure firewall rules, CloudStack modifies `/etc/sysctl.conf` and execute those modifications. This may be harmful for several reasons: