Github user kollyma closed the pull request at:
https://github.com/apache/cloudstack/pull/1449
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-208777850
@kollyma can you close this one if #1487 is indeed the same?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user kollyma commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-208506127
During commit squashing something went wrong.. i could not revert. Here a
new Pull request with exactly the same changes. Sorry for any inconvenience
caused.. and t
Github user kollyma commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-205809122
@Swill: tried to squash the commits shortly from holidays. Did not worked
as expected, messed up my PR. I need to debug this when I am back next week...
---
If you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-204985068
@kollyma Can you squash the commits for me and I will then merge this in.
Thanks...
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-204764789
@swill In the logs I see this:
```
{returns: [u'--2016-04-01 21:41:30-- http://www.google.com/', u'Resolving
www.google.com... 2607:f8b0:4006:807::
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-204634361
The debut of `upr`, so let me know if you want me to change the format.
Also if you want me to add more tests in future runs, please let me know...
Given the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-204633944
### CI Results
### 84/85 SUCCESSFUL
**1 Failure** (this and another similar test seem to fail consistently in
my CI currently)
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-204537583
@remibergsma The test have already been started. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-204532720
@kollyma Please squash the commits.
@swill Let's run integration tests on this before merge.
---
If your project is set up for it, you can reply to this ema
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-204500797
LGTM! please merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-202819883
@swill it is our responsibility as committers to make sure that it is
merged against the right branch. if it is not a new feature and at the moment
4.7 is the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-201531706
I am pretty comfortable with this PR given the scope of the change. Thanks
@milamberspace for testing. Should this be committed against 4.7 and then
forward merged?
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-200296178
Good job. Thanks.
Works fine in my 4.8 test installation (real platform)
Several tests on RV and RVR routers with network restart with/without clean
up
Github user kollyma commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-199709347
The third time is the charm,all checks have passed now! the first time
Jenkins failed and strangely enough the second time Travis failed.
---
If your project is s
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-199517201
@kollyma, maybe just add a comment at the top to mention something like
"pre-fetch the variables so they are not done inline" or something like that
and this should p
Github user kollyma commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-199257722
@cristofolini : thanks! indeed the "Apache CloudStack Plugin - Quota
Service" timed out. After reviewing the PR and the Jenkins output, I can not
see any relations.
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-199059690
@kollyma I like what you did here. Besides apparently speeding up the
iptables setup, the code looks more streamlined this way.
But it seems your build tim
GitHub user kollyma opened a pull request:
https://github.com/apache/cloudstack/pull/1449
speedup iptables setup
PR against 4.7 as discussed with Remi Bergsma. This will speed up the
iptables creation on the virtual router.
Testing showed the following:
with current c
19 matches
Mail list logo
