Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1028
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1028#issuecomment-153673706
LGTM, test runs fine:
```
[root@cs1 MarvinLogs]# less test_vpc_vpn_WK8870/results.txt
Test Remote Access VPN in VPC ... === TestName: test_vpc_r
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1028#issuecomment-153604321
changed the required_hardware tag to true and rebased to master and
retested:
nosetests --with-marvin --marvin-config=../../../mct-zone1-kvm1.cfg -a
tag
template.download will periodically check for the template download status.
I didn't test it but it is a small change. So LGTM!!
On Tue, Nov 3, 2015 at 7:16 PM, michaelandersen wrote:
> Github user michaelandersen commented on a diff in the pull request:
>
> https://github.com/apache/cloudst
Github user michaelandersen commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1028#discussion_r43748177
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -570,127 +584,139 @@ def test_vpc_site2site_vpn(self):
finally:
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1028#discussion_r43742770
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -570,127 +584,139 @@ def test_vpc_site2site_vpn(self):
finally:
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1028#issuecomment-153338894
executed tests with:
nosetests --with-marvin --marvin-config=./mct-zone1-kvm1.cfg -a
tags=advanced test_vpc_vpn.py
---
If your project is set up for
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1028#issuecomment-153338369
Tested change on a KVM hypervisor:
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1028#issuecomment-153338103
@sanjeevneelarapu please review once build checks are completed
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user michaelandersen opened a pull request:
https://github.com/apache/cloudstack/pull/1028
smoke/test_vpc_vpn: Add template wait & refactor
- Added a wait for template download as the test was failing in some
environments
- Removed debug timer in setup and teardown
-
10 matches
Mail list logo
