Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1146#issuecomment-160768113
@remibergsma , I think it would have been a good idea to have squashed your
commits
---
If your project is set up for it, you can reply to this email and
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1146#issuecomment-160766945
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1146#issuecomment-160766514
@rafaelweingartner I agree and I think this needs some TLC indeed.
Investigate why it doesn't work with mvn and then do one global search/replace
for the remain
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1146#issuecomment-160765816
It LGTM,
I would just recommend using âsedâ in combination with âfindâ to
look up for every file that we want to change the version number, in
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1146#issuecomment-160765582
Ok then, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1146#discussion_r46205478
--- Diff: tools/build/build_asf.sh ---
@@ -123,11 +128,7 @@ git clean -f
#create a RC branch
RELEASE_BRANCH="RC"`date +%Y%m%dT%H%M`
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1146#discussion_r46205215
--- Diff: tools/build/build_asf.sh ---
@@ -101,6 +101,11 @@ perl -pi -e "s/-SNAPSHOT//" build/replace.properties
perl -pi -e "s/-SNAPSHOT//" serv
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1146#issuecomment-160764367
The build script now makes a branch that makes sense:
`4.6.1-RC20151130T2206` instead of `4.6-RC20151130T2206`. Also the versions are
updated properly.
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1146#discussion_r46204974
--- Diff: tools/build/build_asf.sh ---
@@ -123,11 +128,7 @@ git clean -f
#create a RC branch
RELEASE_BRANCH="RC"`date +%Y%m%dT%H%M`
---
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1146#discussion_r46204918
--- Diff: tools/build/build_asf.sh ---
@@ -101,6 +101,11 @@ perl -pi -e "s/-SNAPSHOT//" build/replace.properties
perl -pi -e "s/-SNAPSHOT//" services/c
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1146#issuecomment-160761783
Looks good to me. The version-branch should have gone in like this from the
get go.
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1146#discussion_r46201120
--- Diff: tools/build/build_asf.sh ---
@@ -101,6 +101,11 @@ perl -pi -e "s/-SNAPSHOT//" build/replace.properties
perl -pi -e "s/-SNAPSHOT//" ser
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1146
make sure all files are updates with new version
During the previous release I had to edit these manually. This will fix
that so all versions get updated.
You can merge this pull request i
14 matches
Mail list logo
