[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

2015-11-15 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156821894 Yes, let's stick to the rules :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

2015-11-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156821756 so, you have my lgtm, need a second one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

2015-11-15 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156820839 This is an upgrade from 4.6.0 to 4.6.1: ``` INFO [o.a.c.s.l.CloudStackExtendedLifeCycle] (main:null) Running system integrity checker com.cloud.upg

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

2015-11-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156813885 merged with 4.6 branch and: ``` INFO [c.c.s.ManagementServerImpl] (main:ctx-1c73e37e) Startup CloudStack management server... INFO [c.c.c.ClusterM

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

2015-11-15 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156812719 @DaanHoogland I rebased it, as it needs the `checkstyle` fix in 4.6. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

2015-11-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156810107 looks good, let's run a test anyway. the jenkins should run it but it it's running on a INFRA-10703 host so it will most likely fail. --- If your project is s

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

2015-11-15 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1067 implemented upgrade path from 4.6.0 to 4.6.1 The 4.6 branch needs an upgrade path to 4.6.1. I looked at how this was done before and think this will do. Can you give it a second pair of eye