I'm not sure what the protocol is on this, so I just went ahead and checked
in the code to fix the FindBugs issue and noted the PR (674) it is related
to.
Here is the commit:
8fcc76e
On Wed, Aug 12, 2015 at 10:55 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:
> Oh, I read what you wr
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-130536522
No, what you said made perfect sense. :) I just read it incorrectly at
first.
On Wed, Aug 12, 2015 at 11:02 PM, Rajani Karuturi
wrote:
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-130536585
No, what you said made perfect sense. :) I just read it incorrectly at
first.
---
If your project is set up for it, you can reply to this email and have your
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-130536491
BTW, I just noticed, this PR is missing jira issue. It would be good to
have one.
---
If your project is set up for it, you can reply to this email and have your
r
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-130536383
I think I confused you :). Since what is required is primitive long,
findbugs wants you to use parseLong instead of valueOf(which returns Long
object)
---
If your
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-130535316
OK, but - ultimately - I do want to convert it to a primitive long.
On Wed, Aug 12, 2015 at 10:50 PM, Rajani Karuturi
wrote:
> valueOf re
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-130535022
valueOf returns a new Long() where as parseLong returns primitive long.
valueOf causes unboxing as what is required is a primitive long. Using
parseLong will satisf
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-130526955
It doesn't like this line:
long lVolumeId = Long.valueOf(volume.getFolder());
The folder column is a string, but it's storing a long for me (t
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-130523246
@mike-tutkowski master slow build failed as this commit introduced a new
findbugs issues. Can you please take a look?
http://jenkins.buildacloud.org/job/build-maste
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/674
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-130186688
code lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-130100258
I'd eventually like to. I'm in the process of setting up our test
infrastructure so these kinds of tests can run automatically. Right now
it's a combina
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-130091528
Code lgtm. can you publish the tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-129974204
I have internal functional tests that make use of a SolidFire system.
On Tuesday, August 11, 2015, Daan Hoogland wrote:
> I see now unit test
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/674#issuecomment-129902187
I see now unit tests for getUsedBytes() and creatAsync(), the methods you
changed only a generic package org.apache.cloudstack.storage.test. Can you
expand on h
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/674
getUsedBytes should query the SolidFire cluster to acquire the size oâ¦
â¦f the given volume if there is no volume_details info for that volume
(and then create a volume_details row for
16 matches
Mail list logo
