Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/535#issuecomment-119151038
changes looks good. Please go ahead with the merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/535#issuecomment-119087493
@bhaisaab @karuturi @jburwell @everyone: can I get a second LGTM?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/535#issuecomment-118883451
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/535#issuecomment-118866296
Awesome, @DaanHoogland ! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/535#issuecomment-118865807
@jburwell thanks for the guava EqualsTester pointer. @wilderrodrigues I
implemented unit tests for all amd will commit in a second
---
If your project is set u
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/535#issuecomment-117444526
@wilderrodrigues Guava provides
[EqualsTester](http://guava-libraries.googlecode.com/svn-history/r144/trunk/javadoc/com/google/common/testing/EqualsTester.html)
to
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/535#discussion_r33650706
--- Diff:
framework/config/src/org/apache/cloudstack/framework/config/ConfigKey.java ---
@@ -122,6 +122,13 @@ public boolean equals(Object obj) {
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/535#issuecomment-117443363
Hi @DaanHoogland
What about unit tests for the classes that were changed, are those already
in place?
A bunch of well written unit tests wo
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/535#discussion_r33421446
--- Diff:
framework/config/src/org/apache/cloudstack/framework/config/ConfigKey.java ---
@@ -122,6 +122,13 @@ public boolean equals(Object obj) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/535#discussion_r33406307
--- Diff:
framework/config/src/org/apache/cloudstack/framework/config/ConfigKey.java ---
@@ -122,6 +122,13 @@ public boolean equals(Object obj) {
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/535
findbugs equals(obj) implementations go against the contract
these are removed from the call into separate calls
This might very well spectacularly fail in integration tests. really
l
12 matches
Mail list logo
